Repository navigation
Install script improvement - #215
Merged
Merged
Conversation
Weltraumschaf
requested changes
Nov 18, 2020
Clarifying the exit side effect Signed-off-by: Sebastian Franz <sebastian.franz@iteratec.com>
Signed-off-by: Sebastian Franz <sebastian.franz@iteratec.com>
The main part of the script is now easier to read and avoids duplicated code in the interactive/unattended Install functions. This required to use global variables for which resources should be installed. Signed-off-by: Sebastian Franz <sebastian.franz@iteratec.com>
Signed-off-by: Sebastian Franz <sebastian.franz@iteratec.com>
Also add missing -h option in usage string. Signed-off-by: Sebastian Franz <sebastian.franz@iteratec.com>
Installs all resources now only, if the respective directory contains a Chart.yaml file. Signed-off-by: Sebastian Franz <sebastian.franz@iteratec.com>
Signed-off-by: Sven Strittmatter <Sven.Strittmatter@iteratec.com>
Weltraumschaf
force-pushed
the
install-script-improvement
branch
from
November 19, 2020 09:19
ce268fe to
4a331e6
Compare
Weltraumschaf
approved these changes
Nov 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When applied this pull request will add some improvements to the existing install script: