Skip to content

Install script improvement - #215

Merged
Weltraumschaf merged 7 commits into
mainfrom
install-script-improvement
Nov 19, 2020
Merged

Weltraumschaf merged 7 commits into
mainfrom
install-script-improvement

Conversation

@SebieF

@SebieF SebieF commented Nov 18, 2020

Copy link
Copy Markdown
Contributor

When applied this pull request will add some improvements to the existing install script:

  1. Better documentation
  2. Removing duplicated code, clarifying the main function
  3. Separating help from usage
  4. Refactoring some function names to clarify their side effects
  5. Adding a check to avoid the attempt of installing non-existing resources

@SebieF SebieF added the enhancement New feature or request label Nov 18, 2020
@SebieF SebieF added this to the Sprint-31 milestone Nov 18, 2020
@SebieF
SebieF requested a review from Weltraumschaf November 18, 2020 09:46
@SebieF SebieF self-assigned this Nov 18, 2020
Comment thread bin/install.sh Resolved
Comment thread bin/install.sh Resolved
Comment thread bin/install.sh Resolved
Comment thread bin/install.sh Resolved
Comment thread bin/install.sh Resolved
Comment thread bin/install.sh Resolved
Comment thread bin/install.sh Resolved
SebieF and others added 7 commits November 19, 2020 10:02
Clarifying the exit side effect

Signed-off-by: Sebastian Franz <sebastian.franz@iteratec.com>
Signed-off-by: Sebastian Franz <sebastian.franz@iteratec.com>
The main part of the script is now easier to read and avoids duplicated
code in the interactive/unattended Install functions. This required to
use global variables for which resources should be installed.

Signed-off-by: Sebastian Franz <sebastian.franz@iteratec.com>
Signed-off-by: Sebastian Franz <sebastian.franz@iteratec.com>
Also add missing -h option in usage string.

Signed-off-by: Sebastian Franz <sebastian.franz@iteratec.com>
Installs all resources now only, if the respective directory contains a
Chart.yaml file.

Signed-off-by: Sebastian Franz <sebastian.franz@iteratec.com>
Signed-off-by: Sven Strittmatter <Sven.Strittmatter@iteratec.com>
@Weltraumschaf
Weltraumschaf force-pushed the install-script-improvement branch from ce268fe to 4a331e6 Compare November 19, 2020 09:19
@SebieF
SebieF requested a review from Weltraumschaf November 19, 2020 09:24
@Weltraumschaf
Weltraumschaf merged commit ab76a2d into main Nov 19, 2020
@Weltraumschaf
Weltraumschaf deleted the install-script-improvement branch November 19, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants