Fix Issues causing build failure for 4.1.0-alpha.1 release - #1981
Merged
J12934 merged 3 commits intoSep 26, 2023
Conversation
J12934
added
bug
✅ Deploy Preview for docs-securecodebox canceled.
|
o1oo11oo
approved these changes
Sep 25, 2023
Custom scanners are the ones which only have our scb version (once we wrote ourself) This isn't true for amass. Build apparently field as the scanner version docker build arg was missing. Related to secureCodeBox#1980 Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Apparently was missing because it didn't have a empty docs folder so the script never generated anything Not sure how that was missing as the new scanner template has an empty .gitkeep folder Related to secureCodeBox#1980 Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
ssh-scan is still using the official (though deprecated) mozilla image. So it doesn't need a custom build Related to secureCodeBox#1980 Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
J12934
force-pushed
the
bugfix/fix-4-1-0-alpha-1-build-issues
branch
from
September 26, 2023 05:22
b6bb9e8 to
b25eac3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1980
Checklist