Remove duplicate sponsor images from documentation#1944
Closed
Zero3141 wants to merge 2 commits intosecureCodeBox:mainfrom
Closed
Remove duplicate sponsor images from documentation#1944Zero3141 wants to merge 2 commits intosecureCodeBox:mainfrom
Zero3141 wants to merge 2 commits intosecureCodeBox:mainfrom
Conversation
added 2 commits
September 11, 2023 11:43
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
…rus build Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
✅ Deploy Preview for docs-securecodebox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Weltraumschaf
requested changes
Sep 11, 2023
Member
Weltraumschaf
left a comment
Weltraumschaf
left a comment
There was a problem hiding this comment.
We should remove any unnecessary code to build things. So IMO the images should reside in the docusaurus folder, so we do not need to move them around. In the main README we can simply deep link to these files.
Also we should consider if we can simplify the scanner/hooks docs generation, to get rid ofthe untested build scripts.
| const docsConfig = { | ||
| repository: "secureCodeBox/secureCodeBox", // The repository url without the github part of the link | ||
| targetPath: "docs", // This needs to be 'docs' for the docusaurus build, but you may specify a 'docs/<subdirectory>' | ||
| targetPath: ".", // This needs to be '.' as files copied to docs (scanners & hooks) and static (sponsors) folder |
Member
There was a problem hiding this comment.
Id do not really understand the comment here.
| dst: "docs/hooks", | ||
| }, | ||
| { | ||
| src: "resources/sponsors", |
Member
There was a problem hiding this comment.
Why that? We can simply reference the images IMO in the main README directly, right?
Contributor
Author
|
Replaced by #1950 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #942
Checklist