Skip to content

Use empty array for findings where no ips were identified #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
J12934 merged 1 commit into from
Jun 5, 2023
Merged

Use empty array for findings where no ips were identified #1748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scanners/amass/parser/parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ async function parse(fileContent) {
source: domain.source,
domain: domain.domain,
addresses: domain.addresses,
ip_addresses: domain.addresses?.map((address) => address.ip),
ip_addresses: domain.addresses?.map((address) => address.ip) ?? [],
},
};
});
Expand Down
6 changes: 3 additions & 3 deletions scanners/doggo/parser/__snapshots__/parser.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ exports[`should properly parse doggo json file 1`] = `
"doggy_dns_rtt": "260ms",
"doggy_dns_status": "",
"doggy_dns_type": "TXT",
"ip_addresses": undefined,
"ip_addresses": [],
},
"category": "DNS Information",
"description": "DNS record type "TXT" found for "example.com." with address ""v=spf1 -all"".",
Expand All @@ -61,7 +61,7 @@ exports[`should properly parse doggo json file 1`] = `
"doggy_dns_rtt": "260ms",
"doggy_dns_status": "",
"doggy_dns_type": "TXT",
"ip_addresses": undefined,
"ip_addresses": [],
},
"category": "DNS Information",
"description": "DNS record type "TXT" found for "example.com." with address ""wgyf8z8cgvm2qmxpnbnldrcltvk4xqfn"".",
Expand All @@ -77,7 +77,7 @@ exports[`should properly parse doggo json file 1`] = `
"doggy_dns_rtt": "106ms",
"doggy_dns_status": "",
"doggy_dns_type": "MX",
"ip_addresses": undefined,
"ip_addresses": [],
},
"category": "DNS Information",
"description": "DNS record type "MX" found for "example.com." with address "0 .".",
Expand Down
2 changes: 1 addition & 1 deletion scanners/doggo/parser/parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function transformToFindings(targets) {
severity: "INFORMATIONAL",
attributes: {
doggy_dns_type: target.type,
ip_addresses: target.type === "A" || target.type === "AAAA" ? [target.address] : undefined,
ip_addresses: target.type === "A" || target.type === "AAAA" ? [target.address] : [],
doggy_dns_address: target.address,
doggy_dns_status: target.status,
doggy_dns_rtt: target.rtt,
Expand Down
10 changes: 5 additions & 5 deletions scanners/nuclei/parser/__snapshots__/parser.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1047,7 +1047,7 @@ exports[`parses secureCodeBox.io result correctly 1`] = `
"docs-securecodebox.netlify.app.",
],
"hostname": "www.securecodebox.io",
"ip_addresses": null,
"ip_addresses": [],
"matched_at": "https://www.securecodebox.io",
"matched_line": null,
"matcher_name": null,
Expand Down Expand Up @@ -2141,7 +2141,7 @@ exports[`parses the example.com result correctly 1`] = `
"b.iana-servers.net.",
],
"hostname": "example.com",
"ip_addresses": null,
"ip_addresses": [],
"matched_at": "https://example.com",
"matched_line": null,
"matcher_name": null,
Expand Down Expand Up @@ -2193,7 +2193,7 @@ exports[`parses the example.com result correctly 1`] = `
"43547 8 2 615A64233543F66F44D68933625B17497C89A70E858ED76A2145997EDF96A918",
],
"hostname": "example.com",
"ip_addresses": null,
"ip_addresses": [],
"matched_at": "https://example.com",
"matched_line": null,
"matcher_name": null,
Expand Down Expand Up @@ -2252,7 +2252,7 @@ exports[`parses the example.com result correctly 1`] = `
""wgyf8z8cgvm2qmxpnbnldrcltvk4xqfn"",
],
"hostname": "example.com",
"ip_addresses": null,
"ip_addresses": [],
"matched_at": "https://example.com",
"matched_line": null,
"matcher_name": null,
Expand Down Expand Up @@ -2305,7 +2305,7 @@ exports[`parses the example.com result correctly 1`] = `
"0 .",
],
"hostname": "example.com",
"ip_addresses": null,
"ip_addresses": [],
"matched_at": "https://example.com",
"matched_line": null,
"matcher_name": null,
Expand Down
2 changes: 1 addition & 1 deletion scanners/nuclei/parser/parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ async function parse(fileContent) {
category: finding["template-id"],
references: references.length > 0 ? references : null,
attributes: {
ip_addresses: finding.ip ? [finding.ip] : null,
ip_addresses: finding.ip ? [finding.ip] : [],
type: finding.type || null,
hostname,
path: finding.path || null,
Expand Down