Skip to content

Added new ssh-audit scanner to replace deprecated ssh-scan scanner#1713

Merged
sofi0071 merged 55 commits intosecureCodeBox:mainfrom
Reet00:scanner/ssh-audit
May 11, 2023
Merged

Added new ssh-audit scanner to replace deprecated ssh-scan scanner#1713
sofi0071 merged 55 commits intosecureCodeBox:mainfrom
Reet00:scanner/ssh-audit

Conversation

@Reet00
Copy link
Copy Markdown
Contributor

@Reet00 Reet00 commented May 4, 2023

Description

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

Reet00 and others added 30 commits April 25, 2023 09:49
To convert terminal output into file
Signed-off-by: Sofia Lohr <sofia.lohr@iteratec.com>
Signed-off-by: Sofia Lohr <sofia.lohr@iteratec.com>
Signed-off-by: Sofia Lohr <sofia.lohr@iteratec.com>
Signed-off-by: Sofia Lohr <sofia.lohr@iteratec.com>
…ble names for clarity

Signed-off-by: Sofia Lohr <sofia.lohr@iteratec.com>
…dded annotations

Signed-off-by: Sofia Lohr <sofia.lohr@iteratec.com>
Signed-off-by: Sofia Lohr <sofia.lohr@iteratec.com>
Signed-off-by: Sofia Lohr <sofia.lohr@iteratec.com>
Signed-off-by: Sofia Lohr <sofia.lohr@iteratec.com>
…rror

Signed-off-by: Sofia Lohr <sofia.lohr@iteratec.com>
Signed-off-by: Sofia Lohr <sofia.lohr@iteratec.com>
Signed-off-by: Sofia Lohr <sofia.lohr@iteratec.com>
Reet00 added 9 commits May 4, 2023 15:49
Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
…es as a list

Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
removed 'identified_at' to fix bug in unit-testing
changed 'hostname' to 'host' since target can be hostname or ip-address
added cve name in references

Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
@Reet00 Reet00 requested review from Weltraumschaf and removed request for Weltraumschaf May 8, 2023 07:54
Reet00 added 4 commits May 8, 2023 15:22
Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
Copy link
Copy Markdown
Member

@J12934 J12934 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good 🙌
Noticed a couple of issues with the finding format. (Comment for that are primarily in the parser test)
Also a couple of suggestion on how to refactor the parser to make the code a bit more functional and consistent with the other parser code that we have.

sofi0071 and others added 7 commits May 9, 2023 14:27
Co-authored-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Sofia Lohr <sofia.lohr@iteratec.com>
-location for every finding
-location as URI
-added attribute port
-changed template to avoid unneccessary if-statements

Co-authored-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Sofia Lohr <sofia.lohr@iteratec.com>
…dress

Signed-off-by: Sofia Lohr <sofia.lohr@iteratec.com>
…ample.json

Signed-off-by: Sofia Lohr <sofia.lohr@iteratec.com>
Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
sofi0071 and others added 4 commits May 11, 2023 10:33
Co-authored-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>

Signed-off-by: Sofia Lohr <sofia.lohr@iteratec.com>
…fixed typo)

Signed-off-by: Sofia Lohr <sofia.lohr@iteratec.com>
Co-authored-by: Samreet Singh <samreet.singh@iteratec.com>
Co-authored-by: Sofia Lohr <sofia.lohr@iteratec.com>
Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
@sofi0071 sofi0071 merged commit 93cdf2f into secureCodeBox:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scanner Implement or update a security scanner

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Deprecate ssh_Scan

3 participants