Fix hostOrIP helper in CascadingScans#1701
Merged
Weltraumschaf merged 18 commits intomainfrom Jun 5, 2023
Merged
Conversation
J12934
force-pushed
the
bugfix/fix-host-or-ip
branch
from
cb61259 to
cc70b34
Compare
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| eslint | 20 | 1 | 0.63s | ||
| misspell | 24 | 1 | 0.06s | ||
| eslint | 4 | 1 | 0.36s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
Ilyesbdlala
previously approved these changes
Apr 25, 2023
Member
Ilyesbdlala
left a comment
Ilyesbdlala
left a comment
There was a problem hiding this comment.
LGTM, apart from a small suggestion.
J12934
force-pushed
the
bugfix/fix-host-or-ip
branch
from
cc70b34 to
1ab5d31
Compare
J12934
force-pushed
the
bugfix/fix-host-or-ip
branch
from
13b7494 to
95f6eb3
Compare
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
J12934
force-pushed
the
bugfix/fix-host-or-ip
branch
from
95f6eb3 to
a72b7e4
Compare
rfelber
approved these changes
Jun 3, 2023
Member
|
LGTM. But some scanners use |
Member
I suggest to open a new PR for that, in hope we have more small short lived PRs 😬 |
J12934
added a commit
that referenced
this pull request
Jun 5, 2023
J12934
added a commit
that referenced
this pull request
Jun 5, 2023
Followup for #1701 Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
3 tasks
J12934
added a commit
that referenced
this pull request
Jun 5, 2023
Followup for #1701 Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at this mess, i guess the better thing would be to clean this up (by standardizing ips like we did with hostname) before v4?