Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
166 commits
Select commit Hold shift + click to select a range
cc4cb46
First base implementation.
rfelber Sep 28, 2020
9f619d9
Publish Docker Images in regular Docker group
nigthknight Sep 28, 2020
15e12c5
Add Possibility to Change Scanner and Hook Images
nigthknight Sep 28, 2020
3c90ceb
Pin the Tag for custom scanner images
nigthknight Sep 28, 2020
dedc147
Fix CI Syntax
nigthknight Sep 28, 2020
c48db34
Undo Image update for Nikto
nigthknight Sep 30, 2020
025429d
Match Scanner Image Repos with Standards
nigthknight Sep 30, 2020
1819829
Tag scanner-test-scan with Sha
nigthknight Sep 30, 2020
f30a27a
Tag generic-webhook Image with Sha
nigthknight Sep 30, 2020
d5ac13d
Fix CI Syntax
nigthknight Sep 30, 2020
2c28e31
Add image.tag field for nmap
nigthknight Sep 30, 2020
1438973
Pin nmap Version to 7.80
nigthknight Sep 30, 2020
aba8b98
Pin right image for nmap integration test
nigthknight Sep 30, 2020
5aad1f0
Pin Ncrack version to 0.7 for integration Test
nigthknight Sep 30, 2020
ca0243f
Default to Chart Version for image tags
nigthknight Sep 30, 2020
c09dd18
Pin kube-hunter version for integration tests
nigthknight Sep 30, 2020
1148ca3
Nmap Readme Typo Fix
SebieF Sep 28, 2020
1f74ebe
Ncrack dummy-ssh example fix
SebieF Sep 28, 2020
7d88485
Ncrack documentation enhanced
SebieF Sep 28, 2020
726f8f3
Adding new Badges
rfelber Sep 28, 2020
f72c5a2
Fixes parse error due to missing backticks
Sep 28, 2020
a6402f5
Add first version of CONTRIBUTING.md
nigthknight Jul 20, 2020
5cae6f7
[WIP] Update CONTRIBUTING
nigthknight Jul 22, 2020
8341945
[WIP] Add Headline for CLA
nigthknight Jul 22, 2020
b74dec8
Adding init CODE_OF_CONDUCT
nigthknight Jul 22, 2020
7a44b61
Add reference to CODE_OF_CONDUCT
nigthknight Jul 22, 2020
7e7e34e
Adding Table of Contents
nigthknight Jul 22, 2020
9f2539c
Fix Syntax for Table of Contents
nigthknight Jul 22, 2020
70ae7b1
Remove CLA section
nigthknight Jul 27, 2020
ffa8e88
Enclose plain links in angle brackets
nigthknight Jul 27, 2020
6bb1e3c
Escape special char in headings
nigthknight Jul 27, 2020
b6cfd6e
Fix markdown syntax
nigthknight Jul 27, 2020
4df23d2
Change wording
nigthknight Jul 27, 2020
5565eb2
Remove dead link
nigthknight Jul 29, 2020
4cf2d1e
Remove Heading
nigthknight Sep 28, 2020
55200a6
Add Email Address for CoC Complaints
nigthknight Sep 28, 2020
8e41f07
Remove unused file from Repo
nigthknight Sep 28, 2020
9a9b49f
Allow to change attribute names on the s3 secret
J12934 Sep 28, 2020
64e4714
Fixing CodeClimate Integration
rfelber Sep 29, 2020
ffe466f
Trying to support helm2 in parallel to helm3 (WIP).
rfelber Sep 28, 2020
e934931
Extending GitHub Acions to publish HelmCharts v2 additionaly to Helm3
rfelber Sep 28, 2020
b2ec313
Added Helm2 Chart version additional to helm3.
rfelber Sep 28, 2020
898dbc3
Disable istio injection for scan/parser/hook pods
J12934 Sep 29, 2020
49f1a92
Fix copy of crds folder
J12934 Sep 29, 2020
14390b4
Correct Istio AutoInject Flag to a Annotation
J12934 Sep 29, 2020
923f439
Added Helm2 Chart version additional to helm3 for all demo apps.
rfelber Sep 29, 2020
637e67a
Acutally set istio inject to false
J12934 Sep 29, 2020
08c978b
Move adr of securecodebox.io to main repo
Sep 29, 2020
2d57b12
Add adr file about new documentation framework
Sep 29, 2020
414cb57
Add adr for proposing an one-pager
Sep 29, 2020
f7171a7
Update references
SirDany Sep 29, 2020
3d1eebe
Bugfixed HelmChart icons and contact details.
rfelber Sep 29, 2020
49eca1c
Updated github ISSUE_Templates.
rfelber Aug 14, 2020
d0bae85
Added some readme files to improve documentation.
rfelber Sep 10, 2020
e4abb77
Reverted docs changes due to a complete new documentation repo instead.
rfelber Sep 30, 2020
8b41eec
Added a PR template and updated the ISSUE templates.
rfelber Sep 30, 2020
780cdb5
Bugfixing typos and c/p errors.
rfelber Sep 30, 2020
c9afad6
Added a minimum kubernetes version requirement to each helmchart.
rfelber Sep 29, 2020
bd7514b
Added a HelmChart value documentation to each readme based on a templ…
rfelber Sep 29, 2020
01112ea
Add github action to automatically update and commit helm-docs
J12934 Oct 1, 2020
f02f4bd
Move download to curl
J12934 Oct 1, 2020
3546551
Only run on commits
J12934 Oct 1, 2020
ca90d04
Correct glob pattern
J12934 Oct 1, 2020
8eb88c1
Test action without file glob
J12934 Oct 1, 2020
311c0bf
Updating Helm Docs
J12934 Oct 1, 2020
02dea98
Cascading Rules Examples Nmap/Ncrack
SebieF Oct 2, 2020
8007b49
Cascading Integration Test - Test
SebieF Oct 2, 2020
1261904
Updated CI.yaml with Cascading Integration Test
SebieF Oct 2, 2020
24b2c6d
Fixed Filenames
SebieF Oct 2, 2020
9e934a2
Fixed ncrack ssh cascading rules
SebieF Oct 2, 2020
0220eb2
Cascading Rules Integration Tests
SebieF Oct 2, 2020
5286e8e
Bugfix helpers.js
SebieF Oct 2, 2020
60b8759
Add Newline at EOF
nigthknight Oct 5, 2020
913edbb
Remove "experimental" from CRDs Name
J12934 Oct 5, 2020
8a40773
Remove / Rename File with Experimental in their Name
J12934 Oct 5, 2020
68ad262
Fix Ncrack Group Name
J12934 Oct 5, 2020
7d82e2d
Introduce securityContext for operator
J12934 Oct 2, 2020
f2ea5b6
Add securityContext to lurcher
J12934 Oct 2, 2020
6e7749e
Add securityContext to parsers and hooks
J12934 Oct 2, 2020
a21d5f7
Change hook imagePullPolicy to always
J12934 Oct 2, 2020
2271834
Updating Helm Docs
J12934 Oct 2, 2020
029417d
Autoformat values.yaml
J12934 Oct 2, 2020
c25d3c6
Add commentes to operator securityContext
J12934 Oct 2, 2020
c557f54
Add securityContext to nmap
J12934 Oct 2, 2020
540a022
Updating Helm Docs
J12934 Oct 2, 2020
95f435e
Update amass version
J12934 Oct 2, 2020
a0e2940
Add empty securityContext to all scanners
J12934 Oct 2, 2020
2091110
Updating Helm Docs
J12934 Oct 2, 2020
1761669
Apply code review comments
J12934 Oct 5, 2020
9d7bd88
Updating Helm Docs
J12934 Oct 5, 2020
ad0934a
Change default lurcher pullPolicy to Always
J12934 Oct 5, 2020
91595d5
Update logo location
J12934 Oct 5, 2020
15890f8
Correct Nmap & Ncrack Version
J12934 Oct 6, 2020
75b4a48
Fix outdated apiVersion
J12934 Oct 6, 2020
9ae691a
Correct Nikto image name
J12934 Oct 6, 2020
4a7f19d
Added additional parameter to cascading scan
SebieF Oct 7, 2020
e502a7e
Add Newline to improve Output in Shell
nigthknight Oct 5, 2020
758fec7
Update Dashboards for ELK 7.8.0
nigthknight Oct 7, 2020
ff18841
Add Dashboard for Amass
nigthknight Oct 7, 2020
1735481
Add SSL/TLS Dasboard for (SSLyze)
nigthknight Oct 7, 2020
d4f4afe
Add ZAP Dashboard
nigthknight Oct 7, 2020
7a93f4a
Add Nikto Dashboard
nigthknight Oct 7, 2020
5635dcd
Add Portscan Overview (Nmap)
nigthknight Oct 7, 2020
42fbc42
Add SSH Dashboard
nigthknight Oct 7, 2020
6cab9e7
Update ELK Stack to 7.8.0
nigthknight Oct 7, 2020
5182c8b
Add newline to print availible message in its own line
J12934 Oct 7, 2020
e3fb2b7
Fix kibana url for custom release names
J12934 Oct 7, 2020
3719ae3
Update ELK Stack to 7.9.2
nigthknight Oct 7, 2020
48bb632
Pin dashboardImporter image to chart version
J12934 Oct 7, 2020
a41cc75
Updating Helm Docs
J12934 Oct 7, 2020
1b08874
Update Minio to latest version
J12934 Oct 7, 2020
b6ad834
Regenerate readme for test-scan
J12934 Oct 8, 2020
06d8066
Correct index name for zap dashboard
J12934 Oct 8, 2020
9873640
Rename `historyLimit` to `successfulJobsHistoryLimit`
J12934 Oct 12, 2020
37ec2a5
Remove `handlesResultsType` in ParseDefinitions
J12934 Oct 12, 2020
971485c
Regenerate CRD's
J12934 Oct 12, 2020
f2ff45c
Ensure that successfulJobsHistoryLimit default is acutally 3
J12934 Oct 12, 2020
d89c580
Remove Imperative Cascading Scans Hook
J12934 Oct 13, 2020
4be510a
Add ADR Proposal for Documentation Versioning
nigthknight Oct 14, 2020
00a45fd
Update references to github repository
J12934 Oct 14, 2020
b84357c
Expose Zap image as helm config value
J12934 Oct 14, 2020
6a210a3
Fix typo and reorder
J12934 Oct 14, 2020
fe33618
Expose all scanner images consistently via helm values
J12934 Oct 14, 2020
da842a2
Fix helm docs syntax
J12934 Oct 14, 2020
93ad43d
Remove duplicate parserImage.tag description
J12934 Oct 14, 2020
2bf0016
Fix incorrect description in nmap values
J12934 Oct 14, 2020
a0617e2
Regenerate readmes
J12934 Oct 14, 2020
a639d9f
Resolve open todo in cascading scans post install notes
J12934 Oct 14, 2020
5aca0f2
fix: hooks/declarative-subsequent-scans/package.json & hooks/declarat…
snyk-bot Oct 14, 2020
52514a8
fix: upgrade xml2js from 0.4.22 to 0.4.23
snyk-bot Oct 15, 2020
6d40cd0
Updated readme badges to reflect the correct repo after merge to main…
rfelber Oct 14, 2020
7000ed9
fix: upgrade @elastic/elasticsearch from 7.9.0 to 7.9.1
snyk-bot Oct 15, 2020
ec12c47
feature/gitleaks-scanner
Oct 15, 2020
a2029ed
Updating Helm Docs
paulschmelzer Oct 15, 2020
87de764
Adds Readme
Oct 15, 2020
3e483b3
Updating Helm Docs
paulschmelzer Oct 15, 2020
61f3d1f
Move images to official secureCodeBox group
J12934 Oct 15, 2020
a33bffc
Add helm values table to readme template
J12934 Oct 15, 2020
fc27ecb
Updating Helm Docs
J12934 Oct 15, 2020
4b556c2
Update scanners/gitleaks/parser/parser.js
paulschmelzer Oct 15, 2020
787ff88
Update scanners/gitleaks/helm2.Chart.yaml
paulschmelzer Oct 15, 2020
b4ccc77
Update scanners/gitleaks/parser/parser.js
paulschmelzer Oct 15, 2020
cdd92fa
Review changes
Oct 15, 2020
81c7641
Fixes tests
Oct 15, 2020
8998011
Fixes tests
Oct 15, 2020
fd4f4b4
Updating Helm Docs
paulschmelzer Oct 15, 2020
d6090ab
Fixes tests
Oct 15, 2020
ba0d6c8
Bugfixing helmchart kubeVersion field to accept pre-releases also. fi…
rfelber Oct 15, 2020
ecd1eec
Bugfixing image tag references; Add gitleaks to list of officialScanT…
rfelber Oct 15, 2020
7556954
Updating Helm Docs
Oct 15, 2020
bbc9483
fix: upgrade lodash from 4.17.19 to 4.17.20
snyk-bot Oct 16, 2020
792449c
fix: upgrade xml2js from 0.4.22 to 0.4.23
snyk-bot Oct 16, 2020
b9272ef
Delete temporary docs and refer to official docs site
J12934 Oct 15, 2020
68ccc92
Update outdated link to the old website
J12934 Oct 16, 2020
f7c3ee8
Updating Helm Docs
J12934 Oct 16, 2020
bc26283
Update badge to show latest release
J12934 Oct 16, 2020
e83275f
Update install instructions to use the registry
J12934 Oct 16, 2020
597e2ba
Regenerate readme
J12934 Oct 16, 2020
b55073c
Add gitleaks example findings
rfelber Oct 16, 2020
2b4e517
Adding additional ncrack cascadingRules
rfelber Oct 16, 2020
217cfd4
Add Newline at EOF to Make GH Happy
nigthknight Oct 19, 2020
fabfdda
Decrease Minio's default resource limit to 256Mi
J12934 Oct 19, 2020
2f0178c
Updating Helm Docs
J12934 Oct 19, 2020
f074e93
Remove path from README's
J12934 Oct 19, 2020
7a466c7
Remove amass example readme
J12934 Oct 19, 2020
b8de949
Updating Helm Docs
Oct 19, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
27 changes: 19 additions & 8 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -1,31 +1,42 @@
---
name: Bug report
about: Create a report to help us improve
name: "🐞 Bug report"
about: Please create a bug report if you encouter any project specific issue.
labels: bug

---
<!--
Thank you for reporting an issue in our project 🙌

Before opening a new issue, please make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
-->

**Describe the bug**
A clear and concise description of what the bug is.
<!-- A clear and concise description of what the bug is. -->

**To Reproduce**
<!--
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
-->

**Expected behavior**
A clear and concise description of what you expected to happen.
<!-- A clear and concise description of what you expected to happen. -->


**System (please complete the following information):**
<!--
- secureCodeBox Version/Release
- OS: [e.g. iOS]
- Kubernetes Version [command: `kubectl version`]
- Docker Version [command: `docker -v`]
- Docker Compose Version [command: `docker-compose -v`]
- Browser [e.g. chrome, safari]
- Browser [e.g. chrome, safari, firefox,...]
-->

**Screenshots / Logs**
If applicable, add screenshots to help explain your problem.
<!-- If applicable, add screenshots to help explain your problem. -->

**Additional context**
Add any other context about the problem here.
<!-- Add any other context about the problem here. -->
20 changes: 20 additions & 0 deletions .github/ISSUE_TEMPLATE/documentation_issue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
name: "📚 Documentation Issue"
about: "Did you come across parts of our documentation that should be fixed?"
labels: documentation

---
<!--
Thank you for reporting an issue in our documentation 🙌

Before opening a new issue, please make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
-->

## Where to find the issue
<!-- Be as specific as possible by naming the document, page, and ideally paragraph. -->

## Describe the issue
<!-- Please let us know what exactly is the issue with that part of the documentation -->

## Suggested change
<!-- If you have ideas on how to fix this issue, please note them here, or consider creating a Pull Request -->
17 changes: 11 additions & 6 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,22 @@
---
name: Feature request
about: Suggest an idea for this project
name: "➹ Feature request"
about: "Suggest an idea for this project"

---
<!--
Thank you for reporting an issue in our documentation 🙌

Before opening a new issue, please make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
-->

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->

**Describe the solution you'd like**
A clear and concise description of what you want to happen.
<!-- A clear and concise description of what you want to happen. -->

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
<!-- A clear and concise description of any alternative solutions or features you've considered. -->

**Additional context**
Add any other context or screenshots about the feature request here.
<!-- Add any other context or screenshots about the feature request here. -->
38 changes: 38 additions & 0 deletions .github/ISSUE_TEMPLATE/new_hook.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
name: '⚓️ New Hook request'
about: 'Suggest an idea for a new data processing or integration hook in this project.'
labels: 'hook'
---

<!--
Thank you for contributing to our project 🙌

Before opening a new issue, please make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead. Also, please, have a look at our FAQs and existing questions before opening a new question.
-->

## New Hook implementation request

**Is your feature request related to a problem? Please describe.**
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->

**Describe the solution you'd like**
<!-- A clear and concise description of what you want to happen. -->

**Describe alternatives you've considered**
<!-- A clear and concise description of any alternative solutions or features you've considered. -->

**Additional context**
<!-- Add any other context or screenshots about the feature request here. -->

## Steps to implement a new Hook
<!--
Hint: A general guide how to implement a new scanner is documented [here](https://github.com/secureCodeBox/secureCodeBox/tree/master/docs/developer-guide)
-->

- [ ] Create a new folder with the name of the [hook here](https://github.com/secureCodeBox/secureCodeBox/tree/master/hooks)
- [ ] Add a README and give a brief overview of the scanner and its configuration options.
- [ ] Add (optional) a Dockerfile for the scanner if there is no existing one publicly available on dockerHub
- [ ] Use the [Hook-SDK](https://github.com/secureCodeBox/secureCodeBox/tree/master/hook-sdk) to implement a new hook (currently based on NodeJS)
- [ ] Add unit tests with at minimum 80% test coverage
- [ ] Add some example scan.yaml and finding.yaml files in the example folder
- [ ] Implement a new integration test for the hook [here](https://github.com/secureCodeBox/secureCodeBox/tree/master/tests/integration)
46 changes: 25 additions & 21 deletions .github/ISSUE_TEMPLATE/new_security_scanner.md
Original file line number Diff line number Diff line change
@@ -1,35 +1,39 @@
---
name: 'New Security Scanner request'
name: '🚓 New Security Scanner request'
about: 'Suggest an idea for a new security scanner to integrate in this project.'
labels: 'security scanner'
labels: 'scanner'
---

<!--
Thank you for contributing to our project 🙌

Before opening a new issue, please make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead. Also, please, have a look at our FAQs and existing questions before opening a new question.
-->

## New Scanner implementation request

**Is your feature request related to a problem? Please describe.**
- _A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]_
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->

**Describe the solution you'd like**
- _A clear and concise description of what you want to happen._
<!-- A clear and concise description of what you want to happen. -->

**Describe alternatives you've considered**
- _A clear and concise description of any alternative solutions or features you've considered._
<!-- A clear and concise description of any alternative solutions or features you've considered. -->

**Additional context**
- _Add any other context or screenshots about the feature request here._
<!-- Add any other context or screenshots about the feature request here. -->

## Steps to implement a new scanner
> Hint: A general guide how to implement a new scanner is documented [here]( https://github.com/secureCodeBox/secureCodeBox/blob/master/docs/developer-guide/README.md#developing-own-processes)

### Must have
- [ ] Create a [new public secureCodeBox repository](https://github.com/organizations/secureCodeBox/repositories/new) for the scanner implementation
- [ ] Implement a new scanner microservice an reuse some of the existing stuff, if possible
- [ ] Check if there is a [healthcheck](https://github.com/secureCodeBox/secureCodeBox/blob/master/docs/developer-guide/README.md#healthchecks-for-scanner-microservices) for the microservice implemented
- [ ] Implement a [new basic security process](https://github.com/secureCodeBox/secureCodeBox/blob/master/docs/developer-guide/README.md#developing-a-process-model) for the scanner
- [ ] Update the [docker-compose](https://github.com/secureCodeBox/secureCodeBox/blob/master/docker-compose.yml) files and integrate your new scanner there
- [ ] Update the [user guide](https://github.com/secureCodeBox/secureCodeBox/tree/master/docs/user-guide) and [developer guide](https://github.com/secureCodeBox/secureCodeBox/tree/master/docs/developer-guide)
- [ ] Implement a integration test for the scanner [here](https://github.com/secureCodeBox/secureCodeBox/tree/master/test)

### Should have
- [ ] Update the [CLI examples](https://github.com/secureCodeBox/secureCodeBox/tree/master/cli)
- [ ] Update the [Jenkins Pipeline](https://github.com/secureCodeBox/integration-pipeline-jenkins-examples) examples
- [ ] Update the [OpenShift Container Setup](https://github.com/secureCodeBox/ansible-role-securecodebox-openshift)
<!--
Hint: A general guide how to implement a new scanner is documented [here](https://github.com/secureCodeBox/secureCodeBox/tree/master/docs/developer-guide)
-->

- [ ] Create a new folder with the name of the [scanner here](https://github.com/secureCodeBox/secureCodeBox/tree/master/scanners)
- [ ] Add a README.md and give a brief overview of the scanner and its configuration options.
- [ ] Implement a new scanner specific scan-type.yaml
- [ ] Implement a new scanner specific parse-definition.yaml
- [ ] Add (optional) some cascading-rules.yaml
- [ ] Add (optional) a Dockerfile for the scanner if there is no existing one publicly available on dockerHub
- [ ] Use the [parser-SDK](https://github.com/secureCodeBox/secureCodeBox/tree/master/parser-sdk) to implement a new findings parser (currently based on NodeJS)
- [ ] Add unit tests with at minimum 80% test coverage
14 changes: 14 additions & 0 deletions .github/ISSUE_TEMPLATE/question.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
name: "🤨 Question"
about: "If you have *specific* questions about the project, please post them here."
labels: question

---
<!--
Thank you for supporting our project 🙌

Before opening a new issue, please make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead. Also, please, have a look at our FAQs and existing questions before opening a new question.
-->

## Your Question
<!-- Include details about your question. -->
20 changes: 20 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<!--
Thank you for your contribution to our Project 🙌

Before submitting your Pull Request, please take the time to check the points below and provide some descriptive information.
* [ ] If this PR comes from a fork, please [Allow edits from maintainers](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
* [ ] Set a meaningful title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes #41)
* [ ] [Link your Pull Request to an issue](https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) (if applicable)
* [ ] Create Draft pull requests if you need clarification or an explicit review before you can continue your work item.
* [ ] Make sure that your PR is not introducing _unncessary_ reformatting (e.g., introduced by on-save hooks in your IDE)
* [ ] Make sure each new source file you add has a correct license header.
-->

## Checklist

* [ ] Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
* [ ] Make sure `npm test` runs for the whole project.

## Description

<!-- Please be brief in describing which issue is solved by your PR or which enhancement it brings -->
Loading