Skip to content

Generate S3 URLs from go template#1389

Merged
J12934 merged 3 commits intomainfrom
feature/configureable-filenames
Oct 13, 2022
Merged

Generate S3 URLs from go template#1389
J12934 merged 3 commits intomainfrom
feature/configureable-filenames

Conversation

@the-simmon
Copy link
Copy Markdown
Contributor

fixes #1137

This PR adds a config option to the operator where the user can provide a go template to change the default filenames for s3. The default itself did not change compared to previous operators.

Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
@the-simmon the-simmon added the enhancement New feature or request label Oct 5, 2022
@the-simmon the-simmon requested a review from J12934 October 5, 2022 11:43
@the-simmon the-simmon self-assigned this Oct 5, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 5, 2022

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ GO golangci-lint 4 4 4.65s
✅ SPELL misspell 6 0 0.06s
⚠️ YAML prettier 2 1 0.7s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

Copy link
Copy Markdown
Member

@J12934 J12934 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 👍

@J12934 J12934 merged commit e08cf9b into main Oct 13, 2022
@J12934 J12934 deleted the feature/configureable-filenames branch October 13, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

How to add a suffix to output files

2 participants