Add option to specifiy presigned url duration validity#1380
Merged
the-simmon merged 5 commits intomainfrom Dec 13, 2022
Merged
Conversation
the-simmon
added
enhancement
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| golangci-lint | 5 | 5 | 6.72s | ||
| ✅ SPELL | misspell | 6 | 0 | 0.06s | |
| prettier | 1 | 1 | 1.0s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
J12934
requested changes
Sep 28, 2022
J12934
requested changes
Oct 13, 2022
Member
J12934
left a comment
J12934
left a comment
There was a problem hiding this comment.
Can you add the changes to the upgrading guide?
To make sure the users are informed about this change?
Member
|
@the-simmon Can you update this PR? I would love to merge it ;-) |
J12934
previously approved these changes
Dec 12, 2022
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
the-simmon
force-pushed
the
feature/presigned-url-duration
branch
from
9a47399 to
499c26b
Compare
J12934
approved these changes
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #682