Repository navigation
Issue 1353 make fails spaces in path - #1357
Merged
Weltraumschaf merged 43 commits intoOct 26, 2022
Merged
Weltraumschaf merged 43 commits into
Weltraumschaf merged 43 commits into
Conversation
Weltraumschaf
force-pushed
the
issue_1353_make_fails_spaces_in_path
branch
5 times, most recently
from
September 20, 2022 11:30
02775a0 to
fc4af2e
Compare
Weltraumschaf
force-pushed
the
issue_1353_make_fails_spaces_in_path
branch
10 times, most recently
from
September 29, 2022 20:43
18c9c34 to
c15b56f
Compare
Weltraumschaf
marked this pull request as ready for review
September 29, 2022 20:45
Weltraumschaf
requested review from
malexmave
and removed request for
malexmave
September 29, 2022 20:49
malexmave
previously requested changes
Sep 30, 2022
malexmave
left a comment
Member
There was a problem hiding this comment.
Since this breaks the CI with syntax errors on makefile execution, I can trivially say that this needs changes 😁
Weltraumschaf
force-pushed
the
issue_1353_make_fails_spaces_in_path
branch
from
September 30, 2022 12:32
7734bf8 to
f6292e2
Compare
Member
Author
Was a copy&paste bug. Fixed. |
Contributor
|
I cloned this branch into a folder called Is this the desired behavior? Tested on Arch linux. |
Member
Author
Nope, I'll investigate that. |
Weltraumschaf
force-pushed
the
issue_1353_make_fails_spaces_in_path
branch
from
October 6, 2022 09:41
f6292e2 to
bfbea25
Compare
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
…ls in make Problem is, if the body of a conditional is indented like: ``` ifeq (1,1) $(error SNAFU!) endif ``` and the indentation is done with tabs (spaces didn't produce the eror) then the script fails on macOS/FreeBSD because the indented line is interpreted as command. GNU Make on macOS/FreBSD is more strict about that than GNU Make on GNU/Linux system. The script fails with: > Makefile:8: *** commands commence before first target. Stop. This means that a command (with tab indented line) must be written after a recipe (target). The solution is to remove all indentation in conditional blocks. The solution to use spaces was discarded because it is errorprone to accidentally convert them to tabs and introduce a regression, even if the readability of such conditionals suffer. Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
BCP is to add the PHONY to each target instead of one global PHONY target bc it's easier to spot a missing one. Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
…ndition checks Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Unless a user is in an ugly loop of error, install tool, next error, install next tool etc. So one has the chance to install all prerequisites at once. Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
…utput w/o escaping something Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
…e var Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
…file Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
This way it is easier to spot missing ones. Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
…of zap advanced Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
…rely on Bash implememntation Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
This is done that we do not need to include comon.mk everywhere because it is not that common as the name sugest. It is only expoected to be incldued in scanners.mk, hooks.mk, and sdk.mk as a test base. Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
… more meaning Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Give the header comment more meaning. Also some reformatting. Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Weltraumschaf
force-pushed
the
issue_1353_make_fails_spaces_in_path
branch
from
October 26, 2022 08:12
dfcd4a3 to
e426dec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We do not allow white spaces in any path (inside the repo) ans also from outside. A checkout lie
git checkout ... secure\ Code\ Boxwill not work due to limitations of GNU Make. workaround is to stop script with a hopefully helpful message.This PR also cleans up some other stuff in Makefile (see commit messages).
Not fixed: Free BSD. Make from FreeBSD complains about lot of things:
Almost always ifeq/ifdef outside recipe. Since there is no docker available for FreeBSD which is a mandatory prerequisite to build -> Won't fix.
Checklist