Repository navigation
Upgrade Operator & AutoDiscovery to latest kubebuilder 3.6.0 dependencies - #1351
Merged
Merged
Conversation
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 1 | 0 | 0.31s | |
| ✅ DOCKERFILE | hadolint | 3 | 0 | 0.24s | |
| golangci-lint | 5 | 5 | 7.45s | ||
| ✅ SPELL | misspell | 15 | 0 | 0.17s | |
| ✅ YAML | prettier | 7 | 0 | 6.07s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Ilyesbdlala
force-pushed
the
update/update-kubebuilder-version
branch
from
September 29, 2022 14:46
5792e1d to
8e8710d
Compare
Ilyesbdlala
approved these changes
Sep 29, 2022
Ilyesbdlala
left a comment
Member
There was a problem hiding this comment.
LGTM. AFAIK no upgrade notes needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the operator and auto-discovery to use the same dependencies as new projects scaffolded with kubebuilder 3.6.0 and replaces the scaffolded make targets with the new verions.
This allows us to upgrade the used go version to 1.19.
The PR should not be breaking would still put this in the 4.0.0 release rather then the 3.15.0 just to be sure.
Note: kubebuilder 3.6.0 / its go/v3 plugin is still not compatible with apple silicon machines as its using a older version of kustomize. The go/v4 plugin which fixes this is not stable so we're still using the go/v3 plugin. See: https://book.kubebuilder.io/quick-start.html#create-a-project
Checklist