Skip to content

Upgrade Operator & AutoDiscovery to latest kubebuilder 3.6.0 dependencies - #1351

Merged
Ilyesbdlala merged 4 commits into
mainfrom
update/update-kubebuilder-version
Sep 29, 2022
Merged

Ilyesbdlala merged 4 commits into
mainfrom
update/update-kubebuilder-version

Conversation

@J12934

@J12934 J12934 commented Sep 10, 2022

Copy link
Copy Markdown
Member

Description

This PR updates the operator and auto-discovery to use the same dependencies as new projects scaffolded with kubebuilder 3.6.0 and replaces the scaffolded make targets with the new verions.

This allows us to upgrade the used go version to 1.19.

The PR should not be breaking would still put this in the 4.0.0 release rather then the 3.15.0 just to be sure.
Note: kubebuilder 3.6.0 / its go/v3 plugin is still not compatible with apple silicon machines as its using a older version of kustomize. The go/v4 plugin which fixes this is not stable so we're still using the go/v3 plugin. See: https://book.kubebuilder.io/quick-start.html#create-a-project

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.

@J12934 J12934 added dependencies Pull requests that update a dependency file maintenance labels Sep 10, 2022
@J12934 J12934 added this to the v4.0.0 milestone Sep 10, 2022
@J12934 J12934 self-assigned this Sep 10, 2022
@github-actions

github-actions Bot commented Sep 10, 2022 •

Copy link
Copy Markdown

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 1 0 0.31s
✅ DOCKERFILE hadolint 3 0 0.24s
⚠️ GO golangci-lint 5 5 7.45s
✅ SPELL misspell 15 0 0.17s
✅ YAML prettier 7 0 6.07s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@rfelber rfelber added the breaking Changes requiring a major release label Sep 11, 2022
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@Ilyesbdlala
Ilyesbdlala force-pushed the update/update-kubebuilder-version branch from 5792e1d to 8e8710d Compare September 29, 2022 14:46

@Ilyesbdlala Ilyesbdlala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. AFAIK no upgrade notes needed

@Ilyesbdlala
Ilyesbdlala merged commit 474eafa into main Sep 29, 2022
@Ilyesbdlala
Ilyesbdlala deleted the update/update-kubebuilder-version branch September 29, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Changes requiring a major release dependencies Pull requests that update a dependency file maintenance

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants