Skip to content

Upgraded embedded minio chart to latest release v11.9.4 (closes #755) #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
the-simmon merged 1 commit into from
Oct 5, 2022
Merged

Upgraded embedded minio chart to latest release v11.9.4 (closes #755) #1340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions operator/Chart.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
dependencies:
- name: minio
repository: https://helm.min.io/
version: 7.1.2
digest: sha256:6fee974baf705caae258636dbd7b2b89f14230b9ae28aa20da4643d8292c399b
generated: "2020-10-07T11:26:59.229968+02:00"
repository: https://charts.bitnami.com/bitnami
version: 11.9.4
digest: sha256:dcd5c66891556818e8955c7aabd358ca8c87928291b1918611cb333184dd5109
generated: "2022-09-03T17:30:31.769197+02:00"
Comment on lines +3 to +6
Copy link
Copy Markdown
Contributor

@the-simmon the-simmon Sep 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there are reason why you use the bitnami chart instead of the official chart mentioned here? The discussion never came to a final conclusion on what to use.

Copy link
Copy Markdown
Member Author

@rfelber rfelber Oct 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tried the official chart first, but it didn't work and seems to lack some support. Thats why i switched to the bitnami chart. It leaves the impression of a more stable and mature setup.

4 changes: 2 additions & 2 deletions operator/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ maintainers:

dependencies:
- name: minio
version: 7.1.2
repository: https://helm.min.io/
version: 11.9.4
repository: https://charts.bitnami.com/bitnami
condition: minio.enabled

# Artifacthub.io specific annotations
Expand Down
Binary file added operator/charts/minio-11.9.4.tgz
View file
Open in desktop
Binary file not shown.
Binary file removed operator/charts/minio-7.1.2.tgz
View file
Open in desktop
Binary file not shown.
6 changes: 3 additions & 3 deletions operator/templates/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,14 @@ spec:
valueFrom:
secretKeyRef:
name: "{{ .Release.Name }}-minio"
key: accesskey
key: root-user
Copy link
Copy Markdown
Member

@J12934 J12934 Sep 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also require tweaks to the installation docs: https://www.securecodebox.io/docs/getting-started/installation#accessing-the-included-minio-instance

Copy link
Copy Markdown
Member Author

@rfelber rfelber Sep 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Point, thx for the hint

- name: MINIO_SECRET_KEY
valueFrom:
secretKeyRef:
name: "{{ .Release.Name }}-minio"
key: secretkey
key: root-password
- name: S3_BUCKET
value: {{ .Values.minio.defaultBucket.name }}
value: {{ .Values.minio.defaultBuckets }}
{{- else }}
- name: S3_USE_SSL
# Always use tls when connecting to outside the cluster.
Expand Down
6 changes: 2 additions & 4 deletions operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,15 +65,13 @@ lurker:
# -- Image pull policy. One of Always, Never, IfNotPresent. Defaults to Always if :latest tag is specified, or IfNotPresent otherwise. More info: https://kubernetes.io/docs/concepts/containers/images#updating-images
pullPolicy: IfNotPresent

# -- Minio default config. More config options an info: https://github.com/minio/minio/blob/master/helm/minio/values.yaml
minio:
# -- Enable this to use minio as storage backend instead of a cloud bucket provider like AWS S3, Google Cloud Storage, DigitalOcean Spaces etc.
enabled: true
tls:
enabled: false
certSecret: minio-tls
defaultBucket:
enabled: true
name: "securecodebox"
defaultBuckets: "securecodebox"
# Overwrite Minio's default 4Gi memory request
resources:
requests:
Expand Down