Create zap config map even when config is empty#1289
Closed
the-simmon wants to merge 1 commit intomainfrom
Closed
Conversation
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ GIT | git_diff | yes | no | 0.16s | |
| ✅ SPELL | misspell | 1 | 0 | 0.05s | |
| prettier | 1 | 1 | 0.59s | ||
| ✅ YAML | v8r | 1 | 0 | 0.37s | |
| yamllint | 1 | 1 | 0.11s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
renatosazup-zz
approved these changes
Aug 16, 2022
J12934
added a commit
that referenced
this pull request
Aug 17, 2022
#1289 changes the behaviour to always create the configmap. This was intentionally changed, to allow users to manage this configmap outside of helm. Marking this as optional allows scans without it to still work and keep this behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zap-advanced does not create the
zap-advanced-scantype-configconfigmap when it is installed with default values (zapConfigurationis not set). Per default zap-advaned tries to mount this configmap though.secureCodeBox/scanners/zap-advanced/templates/zap-advanced-scan-type.yaml
Lines 6 to 16 in bfd6c45
secureCodeBox/scanners/zap-advanced/values.yaml
Lines 68 to 84 in bfd6c45
This mean that the tutorial on our website does not work, as it does not create the
zap-advanced-scantype-configconfigmap manually. It fails with the following error:MountVolume.SetUp failed for volume "zap-advanced-scantype-config" : configmap "zap-advanced-scantype-config" not found.This PR will change this behavior. Zap-advanded will create an empty
zap-advanced-scantype-configconfigmap if nozapConfigurationis provided to ensure that the mounting of the volume works.