Skip to content

Fixes test dependencies installation for hooks locally #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
the-simmon merged 3 commits into from
Jun 15, 2022
Merged

Fixes test dependencies installation for hooks locally #1219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a42568
Added path of test helpers dir to env paths file
Ilyesbdlala Jun 15, 2022
c435f03
Added step to install dependencies from tests/integration
Ilyesbdlala Jun 15, 2022
eb06233
Removed no longer necessary ci step to install npm dependecies from t…
Ilyesbdlala Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,10 +558,6 @@ jobs:
working-directory: ./hooks
run: npm ci

- name: "Install Test Dependencies"
working-directory: ./tests/integration
run: npm ci

# ---- Unit-Test ----

- name: "Run Unit Tests"
Expand Down
1 change: 1 addition & 0 deletions env-paths.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ HOOK_SDK_DIR = $(PROJECT_DIR)/hook-sdk/nodejs
AUTO_DISCOVERY_DIR = $(PROJECT_DIR)/auto-discovery
HELM_DOCS_DIR = $(PROJECT_DIR)/.helm-docs
TEMPLATES_DIR = $(PROJECT_DIR)/.templates
TESTS_HELPERS_DIR = $(PROJECT_DIR)/tests/integration

SCANNERS_CHART_LIST := $(sort $(wildcard $(SCANNERS_DIR)/*/Chart.yaml))
SCANNERS_TEST_LIST := $(sort $(wildcard $(SCANNERS_DIR)/*/Makefile))
Expand Down
1 change: 1 addition & 0 deletions hooks.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,5 @@ deploy: ## 💾 Deploy this module via HelmChart into namespace "integration-tes
integration-tests: ## 🩺 Start integration test for this module in the namespace "integration-tests"
@echo ".: 🩺 Starting integration test in kind namespace 'integration-tests'."
kubectl -n integration-tests delete scans --all
npm ci --prefix $(TESTS_HELPERS_DIR)
cd $(hook-prefix) && npm ci && npm run test --package jest@$(JEST_VERSION)