Skip to content

Added running unit-tests step to hooks ci steps - #1202

Merged
J12934 merged 3 commits into
secureCodeBox:mainfrom
Ilyesbdlala:bugfix/ci-unit-tests
Jun 7, 2022
Merged

J12934 merged 3 commits into
secureCodeBox:mainfrom
Ilyesbdlala:bugfix/ci-unit-tests

Conversation

@Ilyesbdlala

@Ilyesbdlala Ilyesbdlala commented Jun 1, 2022 •

Copy link
Copy Markdown
Member

Description

Whilst writing the testing documentation, I noticed that the unit-tests are not actually being run during the CI process. Oops?
Fortunately the unit-tests are all successful.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
…ests

This is important by hooks since the integration-tests folder is in the same file
hiearchy as the unit-tests

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
integration-tests-hooks: does both unit and integration-tests
Make scanners: is vague, changed it to Test | Scanner <Scanner name> , as it does
both unit and integration tests

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala added the bug Bugs label Jun 1, 2022
@Ilyesbdlala Ilyesbdlala self-assigned this Jun 1, 2022
@J12934
J12934 merged commit 635b90b into secureCodeBox:main Jun 7, 2022
@Ilyesbdlala
Ilyesbdlala deleted the bugfix/ci-unit-tests branch June 9, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants