Fixes Nightly CI#1169
Fixes Nightly CI#1169J12934 merged 5 commits intosecureCodeBox:mainfrom Ilyesbdlala:bugfix/fix-nightly-ci
Conversation
|
@Weltraumschaf Am I implementing the fork-rebase methodology correctly? How should this be then "merged" to main ? |
What do you mean by "implementing"? A rebased branch is merged the same way as a non-rebased branch with Update: In GitLab one can see if a merge request is fast-forward mergable. Maybe GitHub has the same info somewhere here in the PR, but I couldn't see something like that after skimming through the UI. |
The CI runs on python 3.8.10. The list type does not exist on this version This is the cause for the failing zap-advanced unit-tests Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Corrected the python version with the one that's actually installed in the ubuntu version the python version variable is currently not being used. Replaced "ubuntu-latest" with "ubuntu-20.04" for accuracy Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
It's currently buggy and does not offer AFAIK more scope for our integration-tests Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
This keeps the visibilty of the code. This can simply later on be reverted if the nginx test proves to be necessary Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
I think we have to allow rebase merging in the repo settings : as seen here. This PR should be "fast-forwardable", as I synced my fork with upstream already. |
3 participants
Closes #1132
I also replaced
ubuntu-latestwith the actual version that we useubuntu-20.04in ci.yaml : This done for consistency and also since ubuntu-22.04 LTS is in beta and will soon belatest.