Repository navigation
Allows the Dashboard importer to be built through the makefiles - #1143
Conversation
This is done to avoid uppercase letters in names. for example: docker images not allowed to have uppercase letters Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
…mage These are run as requirements for the corresponding main makefile targets i.e `make docker-build` also runs `dashboard-importer-docker-build` Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Locally, it takes the pods 18 minutes to intialize on a fresh kind cluster. This would increase the CI time required, and should probably go into the nightly build Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
| deploy: ## 💾 Deploy this module via HelmChart into namespace "integration-tests" | ||
| @echo ".: 💾 Deploying '$(name)' $(hook-prefix) HelmChart with the docker tag '$(IMG_TAG)' into kind namespace 'integration-tests'." | ||
| helm -n integration-tests upgrade --install $(name) . --timeout 10m --wait \ | ||
| helm -n integration-tests upgrade --install $(name) . --timeout 20m --wait \ |
There was a problem hiding this comment.
The problem right now is that the deployment of persistence-elastic locally takes at least 18min. I set the timeout 20min to see if that's enough for the CI to get it done. But it doesn't seem like it. (so expect another similar commit 😂) This probably has to be moved to a nightly build.
There was a problem hiding this comment.
Hmmm, 20 mins is even for an integration test very long. We should consider moving such a long running test suite into something like a nightly build.
There was a problem hiding this comment.
@Ilyesbdlala do you know why this is taking so long?
helm upgrade --install persistence-elastic secureCodeBox/persistence-elastic --waitTakes 3 min on my local machine, and 2 min on the second run (once the images were cached)
There was a problem hiding this comment.
@J12934 That was the case for me until I deleted my kind cluster and created a new one to have the same initial state as the CI. The first run takes about 18 min, the next one is less than 1 minute ( after a helm delete persistence-elastic)
The problem is reproducible through the following:
kind delete cluster
kind create cluster
# install SCB
helm repo add secureCodeBox https://charts.securecodebox.io
kubectl create namespace securecodebox-system
helm --namespace securecodebox-system upgrade --install securecodebox-operator secureCodeBox/operator
# install persistence-elastic
cd hooks/persistence-elastic
make docker-build
make docker-export
make kind-import
make deploy # this is where the issue is.There was a problem hiding this comment.
The problem is reproducible through the following:
kind delete cluster kind create cluster # install SCB helm repo add secureCodeBox https://charts.securecodebox.io kubectl create namespace securecodebox-system helm --namespace securecodebox-system upgrade --install securecodebox-operator secureCodeBox/operator # install persistence-elastic cd hooks/persistence-elastic make docker-build make docker-export make kind-import make deploy # this is where the issue is.
For me, it took only about 3-5 min for make deploy to run locally (both on the main branch and the PR branch)..
I had to execute kubectl create namespace integration-tests and cd hook-sdk/nodjs make docker-build in addition to the steps above. I checked by executing kubectl -n integration-test get pods (persistence-elastic and elasticsearch-master are in state Running). OS: Ubuntu 20.04
There was a problem hiding this comment.
The problem is reproducible through the following:
kind delete cluster kind create cluster # install SCB helm repo add secureCodeBox https://charts.securecodebox.io kubectl create namespace securecodebox-system helm --namespace securecodebox-system upgrade --install securecodebox-operator secureCodeBox/operator # install persistence-elastic cd hooks/persistence-elastic make docker-build make docker-export make kind-import make deploy # this is where the issue is.For me, it took only about 3-5 min for make deploy to run locally (both on the main branch and the PR branch).. I had to execute
kubectl create namespace integration-testsandcd hook-sdk/nodjsmake docker-buildin addition to the steps above. I checked by executingkubectl -n integration-test get pods(persistence-elastic and elasticsearch-master are in state Running). OS: Ubuntu 20.04
Yeah, it seems my theory, that the error is due to the amount of time required for persistence elastic to deploy, is false.
The error log from the CI is not helpful. I'm trying to figure out if there's a flag I can set to allow for more debug logs.
There was a problem hiding this comment.
@Ilyesbdlala The pods have been pending over the entire time, meaning that something is missing for kubernetes to start the pods (see the Inspect Post Failure step: https://github.com/secureCodeBox/secureCodeBox/runs/6286731595?check_suite_focus=true#step:27:31)
I've added a kubectl describe pods over the integration-tests namespace. This prints out the detailed output for the pods, which should tell us the reason why kubernetes can't start the pods.
There was a problem hiding this comment.
The hosted github action runners are apperently too small to run elasticsearch...
https://github.com/secureCodeBox/secureCodeBox/runs/6294995302?check_suite_focus=true#step:27:228
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
…ther with --all-namespaces... Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Elasticsearch pods have been pending in the namespace the events should tell us more why that is Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
60b260d to
cbced53
Compare
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Description
closes #1110