[SCB-Bot] Upgraded semgrep from 0.85.0 to 0.92.0#1127
Conversation
|
The reason why the CI is failing at this point is because the semgrep scanner dockerfile is now using the root user, and "RunAsNonRoot" is set on our end. In addition, semgrep fixed a regression that I had previously implemented a workaround for, making the workaround harmful. I set To whoever will review this: Is it okay to have the container run as root, or do we need to have a separate container that we build based on the official one just to change the user the code is running as? According to semgrep, the change to the root user was made because otherwise they had problems running the image as part of a CI job, so it was an intentional change that is unlikely to be reverted soon. |
|
It's "ok'ish", it will likely cause the scan type to fail on a lot of clusters as a lot of cluster enforece running as non root. You can potentially overwrite this semgrep change by using the |
|
I filed an issue with semgrep (where I also corrected some misconception I had about how this change was introduced, so some of the stuff I wrote above was incorrect). Let's see what the response is there before merging this. |
|
A semgrep dev confirmed that the change was intentional and will not be reverted. So, we can either build our own Docker image that simply adds a new user and defaults to using it, or allow the existing image to run as root. Preferences? |
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ GIT | git_diff | yes | no | 0.18s | |
| eslint | 1 | 1 | 0.69s | ||
| ✅ SPELL | misspell | 3 | 0 | 0.04s | |
| prettier | 2 | 1 | 0.51s | ||
| v8r | 2 | 1 | 2.17s | ||
| yamllint | 2 | 1 | 0.13s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
Signed-off-by: secureCodeBoxBot <securecodebox@iteratec.com>
Signed-off-by: Max Maass <max.maass@iteratec.com>
Signed-off-by: Max Maass <max.maass@iteratec.com>
Signed-off-by: Max Maass <max.maass@iteratec.com>
Signed-off-by: Max Maass <max.maass@iteratec.com>
Signed-off-by: Max Maass <max.maass@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
395f706 to
e999efb
Compare
|
@malexmave I've added the breaking label so that we don't forget to put a note about this root change in the release notes |
This is an automated Pull Request by the SCB-Bot. It upgrades semgrep from 0.85.0 to 0.92.0
Release changes : here