Skip to content

Added a CI trigger on Pull request#1123

Merged
Weltraumschaf merged 1 commit intomainfrom
maintenance/ci-on-pull-request
Apr 20, 2022
Merged

Added a CI trigger on Pull request#1123
Weltraumschaf merged 1 commit intomainfrom
maintenance/ci-on-pull-request

Conversation

@Ilyesbdlala
Copy link
Copy Markdown
Member

@Ilyesbdlala Ilyesbdlala commented Apr 20, 2022

Description

relates to #612
This will trigger the CI BOTH on pushes and pull requests opened.
That means that duplicate workflows will happen when a new PR is opened:
Example:
https://github.com/secureCodeBox/secureCodeBox/actions/runs/2194291551
https://github.com/secureCodeBox/secureCodeBox/actions/runs/2194471682

But it will allow for the CI to work on Forks
Reference: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#using-multiple-events

Possible solution: https://github.com/marketplace/actions/skip-duplicate-actions.

Signed-off-by: Ilyes Ben Dlala ilyes.bendlala@iteratec.com

relates to #611
This will trigger the CI BOTH on pushes and pull requests opened.
That means that duplicate workflows will happen when a new PR is opened.
But it will allow for CI to work on Forks
Reference: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#using-multiple-events

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala added the testing Improvements or additions regarding the test setup label Apr 20, 2022
@Ilyesbdlala Ilyesbdlala added this to the v3.10.0 milestone Apr 20, 2022
@Ilyesbdlala Ilyesbdlala self-assigned this Apr 20, 2022
@Ilyesbdlala Ilyesbdlala requested a review from rfelber April 20, 2022 09:05
@Weltraumschaf Weltraumschaf merged commit 1f35fec into main Apr 20, 2022
@Weltraumschaf Weltraumschaf deleted the maintenance/ci-on-pull-request branch April 20, 2022 09:20
@Ilyesbdlala Ilyesbdlala added the planned Issues we will do in the next sprint. label Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

planned Issues we will do in the next sprint. testing Improvements or additions regarding the test setup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants