Conversation
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
the-simmon
added
enhancement
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 1 | 0 | 0.02s | |
| ✅ GIT | git_diff | yes | no | 0.16s | |
| ✅ JSON | eslint-plugin-jsonc | 2 | 0 | 1.45s | |
| ✅ JSON | jsonlint | 2 | 0 | 0.62s | |
| ✅ JSON | prettier | 2 | 0 | 0.49s | |
| ✅ JSON | v8r | 2 | 0 | 3.26s | |
| ✅ SPELL | misspell | 6 | 0 | 0.04s | |
| prettier | 2 | 1 | 0.48s | ||
| ✅ YAML | v8r | 2 | 0 | 2.04s | |
| yamllint | 2 | 1 | 0.12s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
rfelber
reviewed
Apr 19, 2022
Makefile
Outdated
|
|
||
|
|
||
| .PHONY: | ||
| megalint: |
Member
There was a problem hiding this comment.
Suggested change
| megalint: | |
| lint: |
Let's try to keep our makefile targets independent from the technology implementation
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
J12934
approved these changes
May 11, 2022
J12934
approved these changes
May 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Megalinter as a local linter. Closes #739
It adds a CI workflow, and a make target
lint(lints only changed files),lintfix(lints only changed files and tries to apply automatic fixes) andlintall.An important observation:
Currently Megalint is configured to only lint changed files, but for some reason megalint compares the current branch with the newest version of the main branch. This means that a change in main after the feature branch was created will trigger the linting of that changed file in the feature branch, even though the feature branch didn't change the file.
This behavior can be observed in the result of the CI run of this branch. For example
generic webhookwill be linted because it was changed in the main branch, but this branch did not touch those files. (Download the ZIP at the end of the CI run page and check the spell checker report).The number of "unnecessary" linted files will increase with the number of changes in the main branch compared to the feature branch, which means that older feature branches will be spammed with more and more unnecessary findings over time.