Skip to content

Added authentication feature to generic webhook - #1107

Merged
J12934 merged 4 commits into
secureCodeBox:mainfrom
Miker91:feature/authenticated-generic-webhook
Apr 26, 2022
Merged

J12934 merged 4 commits into
secureCodeBox:mainfrom
Miker91:feature/authenticated-generic-webhook

Conversation

@Miker91

@Miker91 Miker91 commented Apr 12, 2022

Copy link
Copy Markdown

The PR is related to the generic-webhook ScanCompletionHook.

This small feature introduces the possibility to post a generic webhook including credentials.

This can be helpful in CI/CD integration when the destination system requires authentication.

Credentials can be stored as Kubernetes secret.

@Ilyesbdlala

Copy link
Copy Markdown
Member

Thank you for your contribution !
In our project, we follow DCO. Each commit, as mentioned here, has to be signed off.
Running the steps found here should do the trick.
The CI pipeline should hopefully run on your next git push.

@Miker91
Miker91 force-pushed the feature/authenticated-generic-webhook branch from 3a1e547 to c4dd178 Compare April 13, 2022 13:56
@Miker91

Miker91 commented Apr 13, 2022

Copy link
Copy Markdown
Author

@Ilyesbdlala Thanks for the advice. Hopefully it is ok now.

Comment thread hooks/generic-webhook/values.yaml Resolved
Miker91 added 3 commits April 15, 2022 09:45
Signed-off-by: Mateusz Majcher <m.majcher91@gmail.com>
Signed-off-by: Mateusz Majcher <m.majcher91@gmail.com>
… a future

Signed-off-by: Mateusz Majcher <m.majcher91@gmail.com>
@Miker91
Miker91 force-pushed the feature/authenticated-generic-webhook branch from f47614f to a2ae029 Compare April 15, 2022 07:46
@rfelber rfelber added the hook Implement or update a hook label Apr 19, 2022
@rfelber

rfelber commented Apr 20, 2022

Copy link
Copy Markdown
Member

Hi @Miker91
thx for your contribution 🙌 and welcome to our community :)
Can you please add yourself to the CONTRIBUTORS.md list as part of our DCO?

Signed-off-by: Mateusz Majcher <m.majcher91@gmail.com>
@J12934
J12934 merged commit 88e8841 into secureCodeBox:main Apr 26, 2022
@rfelber rfelber changed the title Feature/authenticated generic webhook Added authentication feature to generic webhook May 6, 2022
@rfelber rfelber added the enhancement New feature or request label May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request hook Implement or update a hook

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants