Repository navigation
Added authentication feature to generic webhook - #1107
Merged
J12934 merged 4 commits intoApr 26, 2022
Merged
Conversation
Member
Miker91
force-pushed
the
feature/authenticated-generic-webhook
branch
from
April 13, 2022 13:56
3a1e547 to
c4dd178
Compare
Author
|
@Ilyesbdlala Thanks for the advice. Hopefully it is ok now. |
J12934
reviewed
Apr 14, 2022
Signed-off-by: Mateusz Majcher <m.majcher91@gmail.com>
Signed-off-by: Mateusz Majcher <m.majcher91@gmail.com>
… a future Signed-off-by: Mateusz Majcher <m.majcher91@gmail.com>
Miker91
force-pushed
the
feature/authenticated-generic-webhook
branch
from
April 15, 2022 07:46
f47614f to
a2ae029
Compare
Member
|
Hi @Miker91 |
Signed-off-by: Mateusz Majcher <m.majcher91@gmail.com>
J12934
approved these changes
Apr 26, 2022
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is related to the generic-webhook ScanCompletionHook.
This small feature introduces the possibility to post a generic webhook including credentials.
This can be helpful in CI/CD integration when the destination system requires authentication.
Credentials can be stored as Kubernetes secret.