Skip to content

Improved the local makefile workflow - #1102

Merged
RamiSouai merged 3 commits into
mainfrom
maintenance/improve-makefile-local-workflow
Apr 12, 2022
Merged

RamiSouai merged 3 commits into
mainfrom
maintenance/improve-makefile-local-workflow

Conversation

@Ilyesbdlala

@Ilyesbdlala Ilyesbdlala commented Apr 12, 2022 •

Copy link
Copy Markdown
Member

Description

closes #756

Allows the following :

  • Running make test in a hook or scanner folder would run a clean install and run the corresponding unit-tests/integrations-tests
  • Running make test-scanner target=<SCANNER-NAME> in the Project root directory, runs make test in the corresponding Scanner folder
  • Running make test-hook target=<HOOK-NAME> in the Project root directory, runs make test in the corresponding hook folder

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Also added a redirection to the PROJECT_DIR variable. Allowing the
env-path file to find the relative paths

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
… sdks

Also renamed the other targets with the word "clean" in them for better readability

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala added the testing Improvements or additions regarding the test setup label Apr 12, 2022
@Ilyesbdlala Ilyesbdlala changed the title Maintenance/improve makefile local workflow Improved the local makefile workflow Apr 12, 2022
@Ilyesbdlala Ilyesbdlala added the planned Issues we will do in the next sprint. label Apr 12, 2022

@RamiSouai RamiSouai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RamiSouai
RamiSouai merged commit 41e1866 into main Apr 12, 2022
@RamiSouai
RamiSouai deleted the maintenance/improve-makefile-local-workflow branch April 12, 2022 12:19
o1oo11oo pushed a commit to o1oo11oo/secureCodeBox-documentation that referenced this pull request Jul 26, 2023
The clean-integration-tests makefile target was renamed to
reset-integration-tests-namespace in secureCodeBox/secureCodeBox#1102
and therefore doesn't exist anymore.
o1oo11oo pushed a commit to o1oo11oo/secureCodeBox-documentation that referenced this pull request Jul 26, 2023
The clean-integration-tests makefile target was renamed to
reset-integration-tests-namespace in secureCodeBox/secureCodeBox#1102
and therefore doesn't exist anymore.

Fixes secureCodeBox#328

Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
Weltraumschaf pushed a commit to secureCodeBox/documentation that referenced this pull request Jul 26, 2023
The clean-integration-tests makefile target was renamed to
reset-integration-tests-namespace in secureCodeBox/secureCodeBox#1102
and therefore doesn't exist anymore.

Fixes #328

Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

planned Issues we will do in the next sprint. testing Improvements or additions regarding the test setup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Makefile-based Scanner integration test flow is very cumbersome to run locally

3 participants