Repository navigation
Fixes cascading scan hook integration tests - #1073
Merged
RamiSouai merged 29 commits intoApr 12, 2022
Merged
Conversation
until now the hooks were deployed implicitly through the make integration-tests target This makes the output less clear and harder to debug where the failure specifically happened Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
This makes the npm dependecies easier to install and use Also disabled the sslyze test (explanation in the test.js.disabled file) Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
The target install the dependencies for both the nmap-ncrack test and the nmap-sslyze test Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
I'm testing if the location of the package.json matters Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
instead of devDependencies This is done to fix the dependency issue. Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Also made it so the tests use the helpers.js in /tests/integrations Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
added a step to install the dependencies in tests/integrations Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
that can be imported to specific test files Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
…kage.json Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Dashboard importer images are 1.2.3, whilst the chart version is v1.2.3 ("v" prepended)
This is has to be later on changed either in release build CI or how the dashboard importer tag
is handled
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
The deployment of the persistence elastic hook seems to be failling Has to be debugged later on. Disabled for the time being. Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
This reverts commit faddef7. Persistence elastic is disabled due to failing deployment. This fix didnt fix the bug. Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
It caused issues when building hooks docker image Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
…scading-scan hook Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Hooks docker image cannot be built without it Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
The test does not currently run in the CI correctly. Will be diagnosed in a later issue. Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Testing if adding the missing docker build steps fixed the issue Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
This reverts commit 826a1cc. The fix has not worked
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Ilyesbdlala
marked this pull request as ready for review
April 6, 2022 16:10
RamiSouai
approved these changes
Apr 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
npm testruns for the whole project.