Skip to content

Fixes cascading scan hook integration tests - #1073

Merged
RamiSouai merged 29 commits into
mainfrom
maintenance/fix-hook-cascadingscans-integ-tests
Apr 12, 2022
Merged

RamiSouai merged 29 commits into
mainfrom
maintenance/fix-hook-cascadingscans-integ-tests

Conversation

@Ilyesbdlala

@Ilyesbdlala Ilyesbdlala commented Mar 29, 2022 •

Copy link
Copy Markdown
Member
  • Added hook docker image building missing steps to the CI.
  • Fixed the dependency issues that hook integration tests had (The ´test/integrations/helpers.js´ could not be used)
  • Small refactoring to the cascading-scan hook makefile, to make it easier to understand.
  • Persistence elastic integration tests have been temporarily disabled due to Chart versions are not up to date in the github repository #1095

Description

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.

until now the hooks were deployed implicitly through the make integration-tests target
This makes the output less clear and harder to debug where the failure specifically happened

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
This makes the npm dependecies easier to install and use
Also disabled the sslyze test (explanation in the test.js.disabled file)

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
The target install the dependencies for both the nmap-ncrack test
and the nmap-sslyze test

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala added the testing Improvements or additions regarding the test setup label Mar 29, 2022
@Ilyesbdlala Ilyesbdlala self-assigned this Mar 29, 2022
I'm testing if the location of the package.json matters

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
instead of devDependencies
This is done to fix the dependency issue.

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Also made it so the tests use the helpers.js in  /tests/integrations

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
added a step to install the dependencies in tests/integrations

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
that can be imported to specific test files

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
…kage.json

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala added the planned Issues we will do in the next sprint. label Apr 5, 2022
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Ilyesbdlala and others added 16 commits April 5, 2022 17:12
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Dashboard importer images are 1.2.3, whilst the chart version is v1.2.3 ("v" prepended)
This is has to be later on changed either in release build CI or how the dashboard importer tag
is handled

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
The deployment of the persistence elastic hook seems to be failling
Has to be debugged later on. Disabled for the time being.

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
This reverts commit faddef7.

Persistence elastic is disabled due to failing deployment.
This fix didnt fix the bug.

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
It caused issues when building hooks docker image

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
…scading-scan hook

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Hooks docker image cannot be built without it

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
The test does not currently run in the CI correctly.
Will be diagnosed in a later issue.

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Testing if adding the missing docker build steps fixed the issue

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Ilyesbdlala and others added 3 commits April 6, 2022 15:41
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
This reverts commit 826a1cc.

The fix has not worked
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
@Ilyesbdlala
Ilyesbdlala marked this pull request as ready for review April 6, 2022 16:10
@RamiSouai
RamiSouai merged commit c7355a2 into main Apr 12, 2022
@RamiSouai
RamiSouai deleted the maintenance/fix-hook-cascadingscans-integ-tests branch April 12, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

planned Issues we will do in the next sprint. testing Improvements or additions regarding the test setup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants