Skip to content

Removed dependency on Dockerhub for Test-Scan scantypes in integration tests - #1022

Merged
Weltraumschaf merged 19 commits into
mainfrom
feature/test-scan-migration
Mar 16, 2022
Merged

Weltraumschaf merged 19 commits into
mainfrom
feature/test-scan-migration

Conversation

@Ilyesbdlala

@Ilyesbdlala Ilyesbdlala commented Mar 8, 2022 •

Copy link
Copy Markdown
Member

closes #964

Signed-off-by: Ilyes Ben Dlala ilyes.bendlala@iteratec.com

Description

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.

Ilyesbdlala and others added 16 commits March 8, 2022 11:31
test-scan scantype pullPolicy is set to never for testing purporses
to make sure that we use the local image in the kind cluster

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
It is no longer neccessary because `parsers` no longer exists

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
This is done to resolve the issue of the CI not finding the parser-sdk
image

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
this is done to avoid "name already in use" error

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Test-scan gets installed once for all tests

Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Because this breaks later tests and only needs to be set for the test-scan itegration tests

Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Set PRODUCE_INVALID_FINDINGS necessary for integration tests

Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Was set to Never for testing purposes
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
@Ilyesbdlala Ilyesbdlala added the testing Improvements or additions regarding the test setup label Mar 8, 2022
@Ilyesbdlala Ilyesbdlala changed the title Test-scan is now build through the makefile targets Removed dependency on Dockerhub for Test-Scan scantypes in integration tests Mar 8, 2022
@Ilyesbdlala
Ilyesbdlala marked this pull request as ready for review March 8, 2022 15:57
@Ilyesbdlala
Ilyesbdlala requested review from J12934 and malexmave March 8, 2022 15:58
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>

@malexmave malexmave left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not the right person to review this for correctness, as I don't know enough about how the CI works right now, but here's at least one comment that came up while I was going through the diff.

Comment thread .github/workflows/ci.yaml Resolved
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
@Ilyesbdlala Ilyesbdlala added the planned Issues we will do in the next sprint. label Mar 16, 2022
@Weltraumschaf
Weltraumschaf self-requested a review March 16, 2022 14:44

@Weltraumschaf Weltraumschaf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Weltraumschaf
Weltraumschaf merged commit b5172b5 into main Mar 16, 2022
@Weltraumschaf
Weltraumschaf deleted the feature/test-scan-migration branch March 16, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

planned Issues we will do in the next sprint. testing Improvements or additions regarding the test setup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dependency on Dockerhub for Test-Scan scantypes in integration tests

4 participants