Repository navigation
Removed dependency on Dockerhub for Test-Scan scantypes in integration tests - #1022
Merged
Merged
Conversation
test-scan scantype pullPolicy is set to never for testing purporses to make sure that we use the local image in the kind cluster Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
It is no longer neccessary because `parsers` no longer exists Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
This is done to resolve the issue of the CI not finding the parser-sdk image Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
this is done to avoid "name already in use" error Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Test-scan gets installed once for all tests Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Because this breaks later tests and only needs to be set for the test-scan itegration tests Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Set PRODUCE_INVALID_FINDINGS necessary for integration tests Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Was set to Never for testing purposes Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Ilyesbdlala
marked this pull request as ready for review
March 8, 2022 15:57
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
malexmave
reviewed
Mar 10, 2022
malexmave
left a comment
Member
There was a problem hiding this comment.
I'm not the right person to review this for correctness, as I don't know enough about how the CI works right now, but here's at least one comment that came up while I was going through the diff.
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Weltraumschaf
self-requested a review
March 16, 2022 14:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #964
Signed-off-by: Ilyes Ben Dlala ilyes.bendlala@iteratec.com
Description
Checklist
npm testruns for the whole project.