Skip to content

🚧 Makefile commands for integration tests (Consistency) #940

Closed

Description

@malexmave

Currently, scanner integration tests have a global command to be launched, defined in scanners.mk - but all scanners that actually use integration tests overwrite the command in their own Makefiles. The command from the global Makefile does not work for scanners (it uses incorrect paths), so any scanner that does not overwrite it in its own Makefile will not have working integration tests (this was the case for Gitleaks until the changes introduced in #830).

Does someone know why this is the case, and if there is any reason not to just replace the global command with the ones that are used by the scanners? The structure of the global integration tests matches the layout actually used for the hooks (as in: where are the integration test definitions placed?), so is this a case of an incomplete refactoring?

Activity

  1. EndPositive commented on Jan 26, 2022

    @EndPositive
    Contributor

    See this small discussion: #712 (comment)

  2. changed the title [-]🚧 [Consistency] Makefile commands for integration tests[/-] [+]🚧 Makefile commands for integration tests (Consistency)[/+] on Mar 9, 2022
  3. added this to the v3.9.0 milestone on Mar 9, 2022
  4. removed
    plannedIssues we will do in the next sprint.
    on Mar 9, 2022
  5. Ilyesbdlala commented on Mar 9, 2022

    @Ilyesbdlala
    Member

    This issue will be resolved through #756, #965 and #717. Our goal is to minimize allowing scanners from locally overwriting the main scanners.mk makefile. We would like also to remove the makefile dependency on relative paths and working directories. And instead use absolute paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugBugsquestionFurther information is requested

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions