You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
🚧 Makefile commands for integration tests (Consistency) #940
Currently, scanner integration tests have a global command to be launched, defined in scanners.mk - but all scanners that actually use integration tests overwrite the command in their own Makefiles. The command from the global Makefile does not work for scanners (it uses incorrect paths), so any scanner that does not overwrite it in its own Makefile will not have working integration tests (this was the case for Gitleaks until the changes introduced in #830).
Does someone know why this is the case, and if there is any reason not to just replace the global command with the ones that are used by the scanners? The structure of the global integration tests matches the layout actually used for the hooks (as in: where are the integration test definitions placed?), so is this a case of an incomplete refactoring?
changed the title [-]🚧 [Consistency] Makefile commands for integration tests[/-][+]🚧 Makefile commands for integration tests (Consistency)[/+]on Mar 9, 2022
This issue will be resolved through #756, #965 and #717. Our goal is to minimize allowing scanners from locally overwriting the main scanners.mk makefile. We would like also to remove the makefile dependency on relative paths and working directories. And instead use absolute paths.
Activity
EndPositive commentedon Jan 26, 2022
See this small discussion: #712 (comment)
[-]🚧 [Consistency] Makefile commands for integration tests[/-][+]🚧 Makefile commands for integration tests (Consistency)[/+]Ilyesbdlala commentedon Mar 9, 2022
This issue will be resolved through #756, #965 and #717. Our goal is to minimize allowing scanners from locally overwriting the main scanners.mk makefile. We would like also to remove the makefile dependency on relative paths and working directories. And instead use absolute paths.