Skip to content

Stop installing cascading scan rules by default? #914

Closed

Description

@malexmave

At the moment, installing a scanner will also install its cascading scan rules by default. Anecdotally, I can say that this has led to confusion from some users I talked to, and it can also lead to undesireable / unexpected outcomes ("Why does my nmap suddenly start running ncrack if I only wanted to cascade to $otherScanner?").

I would propose to not ship cascading rules by default. The solution causing the least amount of work would be to disable the installation of cascading rules by default, but allow re-enabling it using the helm values during install (basically invert the current behavior). This would be a breaking change, as it would lead to existing cascading rules being uninstalled by Helm on the next update, according to @J12934. Hence, it would be a candidate for SCBv4.

Activity

  1. self-assigned this
    on Sep 7, 2022
  2. moved this from Todo to To Review in secureCodeBoxon Sep 7, 2022
  3. linked a pull request that will close this issueDisable cascading rules by default #1347on Sep 7, 2022
  4. Repository owner moved this from To Review to Done in secureCodeBoxon Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions