Skip to content

[Epic] CI Migration To use Makefile Builds #717

Closed

Description

@nigthknight

Acceptance Criteria:

  • CICD Pipeline Build for all Scanner, Hooks and integration-tests are based on makefile targets

Long Read:

A while ago, we introduced Makefiles to simplify the process of building and testing for all of our project components.
These Makefiles were also required to redesign the CI workflow in a maintainable way and to get rid of all the unnecessary pushes to DockerHub on every push.

For migrating scanners, there is already a new job introduced in the ci.yaml containing most of the scanners in PR #712.

To finish the migration, the following steps need to be done:

Cleanup afterwards:

Activity

  1. linked a pull request that will close this issueBuild Scanners With New Make Targets #712on Oct 12, 2021
  2. malexmave commented on Jan 27, 2022

    @malexmave
    Member

    This should also resolve #940 (duplication of integration-tests target). See discussion in #712 for what the reason for the duplication was, and what the goal state would be.

    Thanks @EndPositive for pointing this out :).

  3. removed their assignment
    on Mar 2, 2022
  4. changed the title [-]CI Migration To Makefile Builds[/-] [+]CI Migration To use Makefile Builds[/+] on Mar 9, 2022
  5. changed the title [-]CI Migration To use Makefile Builds[/-] [+][Epic] CI Migration To use Makefile Builds[/+] on Mar 9, 2022
  6. added this to the v3.9.0 milestone on Mar 9, 2022
  7. modified the milestones: v3.9.0, v3.10.0 on Mar 24, 2022
  8. rfelber commented on Apr 19, 2022

    @rfelber
    Member

    Everything seems to be fixed. Not sure if the last aspect Cache Images for demo-targets is relevant any more 🤔
    If so, we could raise a new issue for that later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ciChanges to the continuous integration setupmaintenanceplannedIssues we will do in the next sprint.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions