You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
The release process didn’t work for AMASS (new makefile based Pipeline) #584
As a secureCodeBox Maintainer I would like to ensure that all secureCodeBox Components are build, tagged and published properly to DockerHub (Docker images) and ArtifactHub (HelmCharts).
Due to the complete rebuild of our CI pipeline based on makefiles, the release didn't work out of the box for the AMASS scanner. He HelmChart was published successfully but the docker images not.
The amass scanner is already migrated to the new makefile based build process so it seems there is some release step missing 😅
Steps To Reproduce
Expected behavior
System (please complete the following information):
I think the problem is that causes this not to work is that we run our CI not on release but on push.
So the build is running for the pushed tag, e.g. v3.0.0 not the releases. So the event name will still be 'push' not 'release'.
I think the problem is that causes this not to work is that we run our CI not on release but on push.
So the build is running for the pushed tag, e.g. v3.0.0 not the releases. So the event name will still be 'push' not 'release'.
Activity
nigthknight commentedon Aug 9, 2021
This probably means we cannot use
to push only on release.
This means we have to find another way to detect if images should be pushed to docker hub or not
J12934 commentedon Aug 10, 2021
I think the problem is that causes this not to work is that we run our CI not on release but on push.
So the build is running for the pushed tag, e.g. v3.0.0 not the releases. So the event name will still be 'push' not 'release'.
See stack overflow threat: https://stackoverflow.com/questions/58475748/github-actions-how-to-check-if-current-push-has-new-tag-is-new-release
I guess best thing to to is to add a release trigger to our ci pipeline?
nigthknight commentedon Aug 10, 2021
I think you are right. We should add the release trigger.
J12934 commentedon Aug 10, 2021
If we just add it we probably build and push all images except amass twice? Do you know of a simple way to prevent this?