Skip to content

The release process didn’t work for AMASS (new makefile based Pipeline) #584

Closed

Description

@rfelber

🐞 Bug report

Describe the bug

As a secureCodeBox Maintainer I would like to ensure that all secureCodeBox Components are build, tagged and published properly to DockerHub (Docker images) and ArtifactHub (HelmCharts).

Due to the complete rebuild of our CI pipeline based on makefiles, the release didn't work out of the box for the AMASS scanner. He HelmChart was published successfully but the docker images not.
The amass scanner is already migrated to the new makefile based build process so it seems there is some release step missing 😅

Steps To Reproduce

Expected behavior

System (please complete the following information):

Screenshots / Logs

Additional context

Activity

  1. added
    ciChanges to the continuous integration setup
    scannerImplement or update a security scanner
    on Aug 9, 2021
  2. nigthknight commented on Aug 9, 2021

    @nigthknight
    Member

    This probably means we cannot use

    push: ${{ github.event_name == 'release' }} # line 348 .github/workflows/ci.yaml

    to push only on release.

    This means we have to find another way to detect if images should be pushed to docker hub or not

  3. J12934 commented on Aug 10, 2021

    @J12934
    Member

    I think the problem is that causes this not to work is that we run our CI not on release but on push.
    So the build is running for the pushed tag, e.g. v3.0.0 not the releases. So the event name will still be 'push' not 'release'.

    See stack overflow threat: https://stackoverflow.com/questions/58475748/github-actions-how-to-check-if-current-push-has-new-tag-is-new-release

    I guess best thing to to is to add a release trigger to our ci pipeline?

  4. nigthknight commented on Aug 10, 2021

    @nigthknight
    Member

    I think the problem is that causes this not to work is that we run our CI not on release but on push.
    So the build is running for the pushed tag, e.g. v3.0.0 not the releases. So the event name will still be 'push' not 'release'.

    See stack overflow threat: stackoverflow.com/questions/58475748/github-actions-how-to-check-if-current-push-has-new-tag-is-new-release

    I guess best thing to to is to add a release trigger to our ci pipeline?

    I think you are right. We should add the release trigger.

  5. J12934 commented on Aug 10, 2021

    @J12934
    Member

    If we just add it we probably build and push all images except amass twice? Do you know of a simple way to prevent this?

  6. self-assigned this
    on Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugBugsciChanges to the continuous integration setupplannedIssues we will do in the next sprint.scannerImplement or update a security scanner

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions