Skip to content

➹ Support ENV and File configuration options for CRDs #212

Closed

Description

@rfelber

Is your feature request related to a problem? Please describe.
As a secureCodeBox developer I would like to use additional extension configuration options utilizing ENV Vars, configMaps, or even secrets in the secureCodeBox CRDs. Some CRDs already had some of this already implemented and also documented but it's not consistent.

For example this PR implements this feature for the scan CRD: Allow Specification of ENV Vars in the Scan CRD

Describe the solution you'd like
Please fill the gaps marked with ❌

(Note: Table updated after secureCodeBox/documentation#231 by @J12934)

SCBv2 CRD Support ENV Documentation ENV Support File Mounts Documentation File Mounts
ScanType ✅ ❌ ✅ ❌
Scan ✅ ✅ ✅ ❌
ParseDefinition ✅ ❌ ✅ ❌
ScanCompletionHook ✅ ✅ ✅ ❌

Additional context

Other Todos

  • Update Ncrack Documentation to use volume mounts on the scan rather than the scan type

Activity

  1. added
    CRDImprovements or additions to CRDs
    on Nov 17, 2020
  2. changed the title [-]Support ENV and File configuration options for CRDs[/-] [+]➹ Support ENV and File configuration options for CRDs[/+] on Nov 18, 2020
  3. J12934 commented on Nov 27, 2020

    @J12934
    Member

    Whoops should not be closed yet

  4. reopened this on Nov 27, 2020
  5. removed their assignment
    on Nov 30, 2020
  6. linked a pull request that will close this issueFixed File Mount Options For Hook CRD #337on Mar 25, 2021
  7. added this to the v3.0.0 milestone on Jun 18, 2021
  8. modified the milestones: v3.0.0, v3.1.0 on Jul 30, 2021
  9. modified the milestones: v3.1.0, v3.2.0 on Aug 30, 2021
  10. modified the milestones: v3.2.0, v3.3.0 on Oct 8, 2021
  11. malexmave commented on Jan 10, 2022

    @malexmave
    Member

    The way I understand the tasks that are left to do here, this issue has been superceded by the four issues linked in my previous comment, since the only thing remaining to do is to update the documentation. If everyone agrees, I think we can close this issue and track the remaining tasks in those four issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    CRDImprovements or additions to CRDsdocumentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions