Skip to content

Generic WebHook API Key is not working as intended #1664

Closed

Description

@J12934

🐞 Bug report

Describe the bug

The api key support for the generic webhook added in #1526 is not working as intended and needs to be fixed before the v4 release.

https://github.com/secureCodeBox/secureCodeBox/blob/main/hooks/generic-webhook/values.yaml#L39-L45

The values are defined as plain string values but in the templates the are references from a secret:

https://github.com/secureCodeBox/secureCodeBox/blob/main/hooks/generic-webhook/templates/webhook-hook.yaml#L34-L45

Suggested Solution

Instead the secrets should not be put in the values but referenced from a pre-existing secret (Like for basic auth: https://github.com/secureCodeBox/secureCodeBox/blob/main/hooks/generic-webhook/templates/webhook-hook.yaml#L34-L45 and the attributes should be renamed to headerNameKey (default maybe headerName) and headerValueKey (default headerValue) to make it clear that these are just the names of the attributes in the secret which are getting configured.

System (please complete the following information):

Only affects unreleased main version.

Activity

  1. added this to the v4.0.0 milestone on Mar 30, 2023
  2. added 2 commits that reference this issue on Apr 3, 2023
  3. added 2 commits that reference this issue on Apr 4, 2023
  4. moved this from Backlog to Done in secureCodeBoxon Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions