You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
serviceAccount annotations and labels are wrongly formatted #1405
I tried to install the helm chart and needed to configure an annotation for the service account so that it can access an s3 bucket. But I got an error:
Helm upgrade failed: YAML parse error on operator/templates/rbac/serviceaccount.yaml: error converting YAML to JSON: yaml: line 9: mapping values are not allowed in this context
or check repository and use helm template values.yaml . --debug > test.yaml and see the output and wrongly formatted serviceAccount.annotations
Expected behavior
We should be able to configure annotations and labels for service accounts.
System (please complete the following information):
secureCodeBox Version/Release 3.15.0
Kubernetes Version [command: kubectl version] - v1.25.2
Screenshots / Logs
Helm upgrade failed: YAML parse error on operator/templates/rbac/serviceaccount.yaml: error converting YAML to JSON: yaml: line 9: mapping values are not allowed in this context
@Weltraumschaf Yeah I also saw some other potential errors, but wanted to first confirm and keep it simple. Shall I close this issue then? Or you want to keep it around until the rest is being inspected/fixed?
Reacted by Jannik Hollenbach and Sven Strittmatter
Activity
fix: Formatting for operator rbac manager service account (closes sec…
ldimitrov commentedon Oct 13, 2022
I created a Pull Request here #1406
fix: Formatting for operator rbac manager service account (closes sec…
Weltraumschaf commentedon Oct 18, 2022
Hi @ldimitrov,
thanks for your contribution ❤️
We just saw that our mega lint action broke more files 😬 So we will push some more PRs on this issue.
Merge pull request #1406 from ldimitrov/bugfix/1405/fix_formatting_se…
J12934 commentedon Oct 18, 2022
There are some more cases i found these but there are likely more:
hooks/notification/templates/configmap.yaml
demo-targets/unsafe-https/templates/service.yaml
demo-targets/swagger-petstore/templates/service.yaml
ldimitrov commentedon Oct 18, 2022
@Weltraumschaf Yeah I also saw some other potential errors, but wanted to first confirm and keep it simple. Shall I close this issue then? Or you want to keep it around until the rest is being inspected/fixed?
Weltraumschaf commentedon Oct 18, 2022
@ldimitrov Yes, we keep it open until all issues introduced by mega linting everything were fixed.
fix: Formatting for operator rbac manager service account (closes sec…