Skip to content

Commit f4e60ea

Browse files
committed
Del leading 'v' In git-tag To create valid Semver
We noticed that our current release process did not use the right docker images anymore. This problem was created after switching to the new build and push docker action because the images are now tagged with a valid semver instead of a version with a leading 'v' but the release tried to use the 'old' version style with a leading 'v'. To resolve this issue we decided to trim the leading 'v' in our Release Action because we want to have consistent tags in Github Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
1 parent 4b2573e commit f4e60ea

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

.github/workflows/helm-charts.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ jobs:
1818
PASSWORD: ${{ secrets.HELM_REGISTRY_PASSWORD }}
1919
run: |
2020
RELEASE_VERSION="${GITHUB_REF#refs/*/}"
21+
# Remove leading 'v' from git tag to create valid semver
22+
RELEASE_VERSION="${RELEASE_VERSION//s}"
2123
# Publish all helm3 charts in all folders containing a `Chart.yaml` file
2224
# https://github.com/koalaman/shellcheck/wiki/SC2044
2325
find . -type f -name Chart.yaml -print0 | while IFS= read -r -d '' chart; do
@@ -37,6 +39,8 @@ jobs:
3739
PASSWORD: ${{ secrets.HELM_REGISTRY_PASSWORD }}
3840
run: |
3941
RELEASE_VERSION="${GITHUB_REF#refs/*/}"
42+
# Remove leading 'v' from git tag to create valid semver
43+
RELEASE_VERSION="${RELEASE_VERSION//s}"
4044
# Publish all helm2 charts in all folders containing a `helm2.Chart.yaml` file
4145
# https://github.com/koalaman/shellcheck/wiki/SC2044
4246
find . -type f -name helm2.Chart.yaml -print0 | while IFS= read -r -d '' chart; do

0 commit comments

Comments
 (0)