Skip to content

Commit bc65847

Browse files
J12934J12934
committed
remove unused references to userIds and usernames which do not need to be set anymore
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
1 parent 40a5ba4 commit bc65847

3 files changed

Lines changed: 2 additions & 17 deletions

File tree

‎hooks/persistence-defectdojo/.helm-docs.gotmpl‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ The _DefectDojo_ hook will send all scan results to _DefectDojo_, including thos
6363
Installing the _DefectDojo_ persistenceProvider hook will add a _ReadAndWrite Hook_ to your namespace.
6464

6565
```bash
66-
kubectl create secret generic defectdojo-credentials --from-literal="username=admin" --from-literal="apikey=08b7..."
66+
kubectl create secret generic defectdojo-credentials --from-literal="apikey=08b7..."
6767
6868
helm upgrade --install dd oci://ghcr.io/securecodebox/helm/persistence-defectdojo \
6969
--set="defectdojo.url=https://defectdojo-django.default.svc"
@@ -157,7 +157,6 @@ _DefectDojo_ >2.0.0 refined their user access rights, allowing you to restrict t
157157

158158
#### Limitations of the Low Privileged Mode
159159

160-
- Instead of the username, the userId **must** be configured as the low privileged can't use the users list api to look up its own userId.
161160
- The configured product type must exist beforehand as the low privileged user isn't permitted to create a new one
162161
- The hook will not create / link the engagement to the _secureCodeBox_ orchestration engine tool type.
163162
- The low privileged user must have at least the `Maintainer` role in the configured product type.
@@ -169,8 +168,7 @@ kubectl create secret generic defectdojo-credentials --from-literal="apikey=08b7
169168
170169
helm upgrade --install dd oci://ghcr.io/securecodebox/helm/persistence-defectdojo \
171170
--set="defectdojo.url=http://defectdojo-django.default.svc" \
172-
--set="defectdojo.lowPrivilegedMode=true" \
173-
--set="defectdojo.authentication.userId=42"
171+
--set="defectdojo.lowPrivilegedMode=true"
174172
```
175173

176174
### DefectDojo minimum severity
@@ -288,7 +286,6 @@ included [Minio Instance](https://www.securecodebox.io/docs/getting-started/inst
288286
and upload them to a GitHub Gist.
289287
4. Set the following environment variables:
290288
- `DEFECTDOJO_URL`: URL to your DefectDojo server, e.g `DEFECTDOJO_URL="http://192.168.0.1:8080"`. (Required by _defectdojo-client-java_ lib.)
291-
- `DEFECTDOJO_USERNAME`: User you want to use to import findings, e.g `DEFECTDOJO_USERNAME="admin"`. (Required by _defectdojo-client-java_ lib.)
292289
- `DEFECTDOJO_APIKEY`: API key, e.g. `DEFECTDOJO_APIKEY="..."` (Can be fetched from the _DefectDojo_ API information page). (Required by _defectdojo-client-java_ lib.)
293290
- `DEFECTDOJO_IS_DEV`: To enable dev mode, which loads a k8s config from `~/.kube/config`, e.g. `DEFECTDOJO_IS_DEV="true"`.
294291
- `SCAN_NAME`: (optional) For mocking purpose when debugging locally, e.g `SCAN_NAME="nmap-scanme.nmap.org"`. Must be set exactly to the name of the scan used in step 2. Typically, this is set automatically by _secureCodeBox_.

‎hooks/persistence-defectdojo/templates/persistence-provider.yaml‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,6 @@ spec:
2525
env:
2626
- name: DEFECTDOJO_URL
2727
value: {{ .Values.defectdojo.url | quote }}
28-
{{- if .Values.defectdojo.authentication.userId }}
29-
- name: DEFECTDOJO_USER_ID
30-
value: {{ .Values.defectdojo.authentication.userId | quote }}
31-
{{- else }}
32-
- name: DEFECTDOJO_USERNAME
33-
valueFrom:
34-
secretKeyRef:
35-
name: {{ .Values.defectdojo.authentication.userSecret }}
36-
key: {{ .Values.defectdojo.authentication.usernameKey }}
37-
{{- end }}
3828
- name: DEFECTDOJO_APIKEY
3929
valueFrom:
4030
secretKeyRef:

‎hooks/persistence-defectdojo/tests/__snapshot__/persistence-defectdojo_test.yaml.snap‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ matches the snapshot:
2828
env:
2929
- name: DEFECTDOJO_URL
3030
value: http://defectdojo-django.default.svc
31-
- name: DEFECTDOJO_USER_ID
32-
value: foo
3331
- name: DEFECTDOJO_APIKEY
3432
valueFrom:
3533
secretKeyRef:

0 commit comments

Comments
 (0)