Skip to content

Commit b16511f

Browse files
committed
Removed unnecessary intializing of scannerVersions in scanner Dockerfiles
The scannerVersion is and should always be overwritten by the makefiles/i.e the appVersion in the helm charts. This means that having a preset version in the Dockerfile leads to confusion about the actual version being used. Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
1 parent 608bbb9 commit b16511f

5 files changed

Lines changed: 5 additions & 5 deletions

File tree

‎scanners/kube-hunter/scanner/Dockerfile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
#
33
# SPDX-License-Identifier: Apache-2.0
44

5-
ARG scannerVersion=latest
5+
ARG scannerVersion
66
FROM aquasec/kube-hunter:${scannerVersion}
77
RUN adduser -S -H -u 1001 kubehunter
88
USER kubehunter

‎scanners/kubeaudit/scanner/Dockerfile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
FROM golang:1.17 AS builder
66

7-
ARG scannerVersion=latest
7+
ARG scannerVersion
88

99
# no need to include cgo bindings
1010
ENV CGO_ENABLED=0 GOOS=linux GOARCH=amd64

‎scanners/ncrack/scanner/Dockerfile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# SPDX-License-Identifier: Apache-2.0
44

55
FROM ubuntu:20.04
6-
ARG scannerVersion=latest
6+
ARG scannerVersion
77

88
RUN apt-get update \
99
&& apt-get install ncrack=$scannerVersion+debian-1build1 -y \

‎scanners/nmap/scanner/Dockerfile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# SPDX-License-Identifier: Apache-2.0
44

55
FROM alpine:3.15
6-
ARG scannerVersion=latest
6+
ARG scannerVersion
77
RUN apk add --no-cache nmap=$scannerVersion nmap-scripts=$scannerVersion
88
RUN addgroup --system --gid 1001 nmap && adduser nmap --system --uid 1001 --ingroup nmap
99
USER 1001

‎scanners/whatweb/scanner/Dockerfile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
FROM ruby:latest
66

7-
ARG scannerVersion=v0.5.5
7+
ARG scannerVersion
88
RUN git clone --depth 1 --branch $scannerVersion https://github.com/urbanadventurer/WhatWeb.git \
99
&& cd WhatWeb \
1010
&& make install

0 commit comments

Comments
 (0)