@@ -18,13 +18,14 @@ npm-test-all: ## Runs all Jest based test suites.
1818.PHONY : test-all
1919test-all : install-operator install-sdks # # Runs all makefile based test suites (unit + integration Tests).
2020 @echo " Running make test for all scanner and hook modules..."
21- # 1353 This will break if one has spaces in the path from $(PROJECT_DIR)
21+ # FIXME: # 1353 This will break if one has spaces in the path from $(PROJECT_DIR)
2222 @for dir in $(SCANNERS_TEST_LIST) $(HOOKS_TEST_LIST); do \
2323 echo "🧪 Test Suite for $${dir}" && cd $$(dirname $$dir) && $(MAKE) -s test || exit 1; \
2424 done
2525
2626.PHONY : install-operator
2727install-operator : # # Install the operator for makefile based testing.
28+ # FIXME: #1353 This will break if one has spaces in the path from $(PROJECT_DIR)
2829 @echo "Installing the operator for makefile based testing..."
2930 cd "$(OPERATOR_DIR)" && $(MAKE) -s docker-build docker-export kind-import helm-deploy
3031
@@ -36,33 +37,36 @@ install-sdks: ## Install the SDKs for makefile based testing.
3637
3738.PHONY : readme
3839readme : # # Generate README.md based on Chart.yaml and template.
40+ # FIXME: #1353 This will break if one has spaces in the path from $(PROJECT_DIR)
3941 "$(BIN_DIR)/generate-helm-docs.sh" --readme $(PROJECT_DIR) $(HELM_DOCS_DIR)
4042
4143.PHONY : hook-docs
4244hook-docs : # # Generate documentation for hooks.
43- # 1353 This will break if one has spaces in the path from $(PROJECT_DIR)
45+ # FIXME: # 1353 This will break if one has spaces in the path from $(PROJECT_DIR)
4446 @for chart in $(HOOKS_CHART_LIST); do \
4547 $(BIN_DIR)/generate-helm-docs.sh --hook $${chart} $(HELM_DOCS_DIR); \
4648 done
4749
4850.PHONY : scanner-docs
4951scanner-docs : # # Generate documentation for scanners.
50- # 1353 This will break if one has spaces in the path from $(PROJECT_DIR)
52+ # FIXME: # 1353 This will break if one has spaces in the path from $(PROJECT_DIR)
5153 @for chart in $(SCANNERS_CHART_LIST); do \
5254 $(BIN_DIR)/generate-helm-docs.sh --scanner $${chart} $(HELM_DOCS_DIR); \
5355 done
5456
5557.PHONY : operator-docs
5658operator-docs : # # Generate documentation for the operator.
59+ # FIXME: #1353 This will break if one has spaces in the path from $(PROJECT_DIR)
5760 "$(BIN_DIR)/generate-helm-docs.sh" --operator $(OPERATOR_DIR)/Chart.yaml $(HELM_DOCS_DIR)
5861
5962.PHONY : auto-discovery-docs
6063auto-discovery-docs : # # Generate documentation for the auto-discovery.
64+ # FIXME: #1353 This will break if one has spaces in the path from $(PROJECT_DIR)
6165 "$(BIN_DIR)/generate-helm-docs.sh" --operator $(AUTO_DISCOVERY_DIR)/kubernetes/Chart.yaml $(HELM_DOCS_DIR)
6266
6367.PHONY : demo-target-docs
6468demo-target-docs : # # Generate documentation for demo targets.
65- # 1353 This will break if one has spaces in the path from $(PROJECT_DIR)
69+ # FIXME: # 1353 This will break if one has spaces in the path from $(PROJECT_DIR)
6670 @for chart in $(DEMO_TARGETS_CHART_LIST); do \
6771 $(BIN_DIR)/generate-helm-docs.sh --demo-target $${chart} $(HELM_DOCS_DIR); \
6872 done
8892
8993.PHONY : test-scanner
9094test-scanner : # # Shorthand to test a scanner w/o changing in its subdirectory.
95+ # FIXME: #1353 This will break if one has spaces in the path from $(PROJECT_DIR)
9196ifdef NAME
9297 $(MAKE) test -C $(SCANNERS_DIR)/$(NAME)
9398else
96101
97102.PHONY : test-hook
98103test-hook : # # Shorthand to test a hook w/o changing in its subdirectory.
104+ # FIXME: #1353 This will break if one has spaces in the path from $(PROJECT_DIR)
99105ifdef NAME
100106 $(MAKE) test -C $(HOOKS_DIR)/$(NAME)
101107else
0 commit comments