Skip to content

Commit 907df23

Browse files
committed
Reduce verbosity of error logs to not disclose any confidential data
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
1 parent 1d90286 commit 907df23

1 file changed

Lines changed: 4 additions & 11 deletions

File tree

‎lurker/main.go‎

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import (
1313
"log"
1414
"net"
1515
"net/http"
16-
"net/http/httputil"
1716
"net/url"
1817
"os"
1918
"time"
@@ -142,17 +141,11 @@ func uploadFile(path, url string) (error, bool) {
142141
return nil, false
143142
}
144143

145-
log.Printf("File upload returned non 2xx status code (%d)", res.StatusCode)
146-
147-
// Dump response for debugging purposes
148-
resultBytes, dumpErr := httputil.DumpResponse(res, true)
149-
if dumpErr != nil {
150-
log.Printf("failed to dump out failed requests to upload scan report to the s3 bucket: %v", dumpErr)
151-
// drain the body so that the connection can be reused by the next attempt
152-
io.Copy(io.Discard, res.Body)
144+
resultBytes, readErr := io.ReadAll(res.Body)
145+
if readErr != nil {
146+
log.Printf("File upload returned status code %d; failed to read response body: %v", res.StatusCode, readErr)
153147
} else {
154-
log.Println("Response of Failed Request:")
155-
log.Println(string(resultBytes))
148+
log.Printf("File upload returned status code %d with response body: %s", res.StatusCode, resultBytes)
156149
}
157150

158151
return fmt.Errorf("lurker failed to upload scan result file. File upload returned non 2xx status code (%d)", res.StatusCode), false

0 commit comments

Comments
 (0)