Skip to content

Commit 698adef

Browse files
committed
#1353 Escape paths to scripts in make targets
This is done because $(PROJECT_DIR) may contain spaces in the path. Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
1 parent 6c13d25 commit 698adef

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

Makefile

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,17 +27,17 @@ test-all: install-operator install-sdks ## Runs all makefile based test suites (
2727
.PHONY: install-operator
2828
install-operator: ## Install the operator for makefile based testing.
2929
@echo "Installing the operator for makefile based testing..."
30-
cd $(OPERATOR_DIR) && $(MAKE) -s docker-build docker-export kind-import helm-deploy
30+
cd "$(OPERATOR_DIR)" && $(MAKE) -s docker-build docker-export kind-import helm-deploy
3131

3232
.PHONY: install-sdks
3333
install-sdks: ## Install the SDKs for makefile based testing.
3434
@echo "Installing the SDKs (parser, hooks) for makefile based testing..."
35-
cd $(PARSER_SDK_DIR) && $(MAKE) -s docker-build
36-
cd $(HOOK_SDK_DIR) && $(MAKE) -s docker-build
35+
cd "$(PARSER_SDK_DIR)" && $(MAKE) -s docker-build
36+
cd "$(HOOK_SDK_DIR)" && $(MAKE) -s docker-build
3737

3838
.PHONY: readme
3939
readme: ## Generate README.md based on Chart.yaml and template.
40-
$(BIN_DIR)/generate-helm-docs.sh --readme $(PROJECT_DIR) $(HELM_DOCS_DIR)
40+
"$(BIN_DIR)/generate-helm-docs.sh" --readme $(PROJECT_DIR) $(HELM_DOCS_DIR)
4141

4242
.PHONY: hook-docs
4343
hook-docs: ## Generate documentation for hooks.
@@ -53,11 +53,11 @@ scanner-docs: ## Generate documentation for scanners.
5353

5454
.PHONY: operator-docs
5555
operator-docs: ## Generate documentation for the operator.
56-
$(BIN_DIR)/generate-helm-docs.sh --operator $(OPERATOR_DIR)/Chart.yaml $(HELM_DOCS_DIR)
56+
"$(BIN_DIR)/generate-helm-docs.sh" --operator $(OPERATOR_DIR)/Chart.yaml $(HELM_DOCS_DIR)
5757

5858
.PHONY: auto-discovery-docs
5959
auto-discovery-docs: ## Generate documentation for the auto-discovery.
60-
$(BIN_DIR)/generate-helm-docs.sh --operator $(AUTO_DISCOVERY_DIR)/kubernetes/Chart.yaml $(HELM_DOCS_DIR)
60+
"$(BIN_DIR)/generate-helm-docs.sh" --operator $(AUTO_DISCOVERY_DIR)/kubernetes/Chart.yaml $(HELM_DOCS_DIR)
6161

6262
.PHONY: demo-target-docs
6363
demo-target-docs: ## Generate documentation for demo targets.

0 commit comments

Comments
 (0)