Skip to content
This repository was archived by the owner on Feb 26, 2021. It is now read-only.

Add optional property to defect dojo persistence provider #65

Merged
MartinLang1 merged 1 commit into from
Jan 30, 2019
Merged

Add optional property to defect dojo persistence provider #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 25 additions & 9 deletions ...nceprovider/src/main/java/io/securecodebox/persistence/DefectDojoPersistenceProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
import org.springframework.stereotype.Component;

Expand All @@ -47,6 +48,9 @@
public class DefectDojoPersistenceProvider implements PersistenceProvider {
private static final Logger LOG = LoggerFactory.getLogger(DefectDojoPersistenceProvider.class);

@Value("${securecodebox.persistence.defectdojo.optional:false}")
protected boolean isOptional;

@Autowired
DefectDojoService defectDojoService;

Expand All @@ -66,6 +70,18 @@ public void persist(SecurityTest securityTest) throws PersistenceException {
LOG.debug("Starting defectdojo persistence provider");
LOG.debug("RawFindings: {}", securityTest.getReport().getRawFindings());

try {
persistInDefectDojo(securityTest);
} catch (Exception e) {
// ignore error if defect dojo provider is set to optional
if(isOptional) {
LOG.error("Failed to persist security test in defect dojo", e);
return;
} else throw e;
}
}

private void persistInDefectDojo(SecurityTest securityTest) throws PersistenceException {
checkConnection();
checkToolTypes();

Expand All @@ -77,15 +93,15 @@ public void persist(SecurityTest securityTest) throws PersistenceException {
long userUrl = defectDojoService.retrieveUserId(username);

List<String> results = getDefectDojoScanName(securityTest.getName()).equals("Generic Findings Import") ? getGenericResults(securityTest) : getRawResults(securityTest);
for (String result : results) {
defectDojoService.createFindings(
result,
engagementId,
userUrl,
currentDate(),
getDefectDojoScanName(securityTest.getName())
);
}
for (String result : results) {
defectDojoService.createFindings(
result,
engagementId,
userUrl,
currentDate(),
getDefectDojoScanName(securityTest.getName())
);
}
}

static final String GIT_SERVER_NAME = "Git Server";
Expand Down