You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Class ImportScanService uses ...Map<String, Object> which is an unnecessary anti pattern in Java. We should use <String,String> Instead, since the underlying REST call only deals with string anyway.
Activity
secureCodeBox#36 Reformatting
secureCodeBox#36 Rename factory method for RestTemplate
secureCodeBox#36 Give variable a name to reflect what it is
secureCodeBox#36 Make some vars final to avoid accidental reassign
secureCodeBox#36 Simplify code
secureCodeBox#36 Move overloaded method beneath the origin method
secureCodeBox#36 Explixit call to super for dedicated constructor
secureCodeBox#36 Prohibit null as ctr argument
secureCodeBox#36 Make fields private and final bc internal state must…
secureCodeBox#36 Use API constant instead of hard coded header name
282 remaining items
secureCodeBox#36 We assume a configured proxy only if username/passwo…
#36 Add tests for auth header generation
#36 USe better name forfacotry method
#36 Simplify syntax of method
#36 Decompose method to make code testable
#36 Decompose method to make code testable
#36 Decompose method to make code testable
#36 Reformatting
#36 Decompose method to make code testable
#36 Use method chaining for better readability
#36 We assume a configured proxy only if username/password are set
Weltraumschaf commentedon Feb 9, 2024
Type safty is improved, but not perfect. We want to remove Spring anyway, so closed.