Skip to content

Remove the duplicate core Skinny layer - #5242

Merged
gpotter2 merged 1 commit into
secdev:masterfrom
guedou:fix/issue-3938-skinny-contrib
Oct 25, 2026
Merged

gpotter2 merged 1 commit into
secdev:masterfrom
guedou:fix/issue-3938-skinny-contrib

Conversation

@guedou

@guedou guedou commented Oct 21, 2026

Copy link
Copy Markdown
Member

@gpotter2 this is an agentic attempt at solving #3938

@guedou
guedou force-pushed the fix/issue-3938-skinny-contrib branch from 64f4a5e to b940c48 Compare October 21, 2026 15:45
@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.54%. Comparing base (770ab0f) to head (cdcdef7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5242      +/-   ##
==========================================
+ Coverage   80.41%   80.54%   +0.12%     
==========================================
  Files         376      375       -1     
  Lines       98405    98399       -6     
==========================================
+ Hits        79137    79258     +121     
+ Misses      19268    19141     -127     
Files with missing lines Coverage Δ
scapy/config.py 85.69% <ø> (ø)
scapy/contrib/skinny.py 84.96% <100.00%> (+84.96%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guedou
guedou force-pushed the fix/issue-3938-skinny-contrib branch from 1d74c26 to 5e7c64a Compare October 22, 2026 07:19
@gpotter2
gpotter2 force-pushed the fix/issue-3938-skinny-contrib branch from 5e7c64a to 68d9e01 Compare October 24, 2026 16:05
Comment thread scapy/contrib/skinny.py Outdated
@gpotter2 gpotter2 added needs rework/cleanup cleanup Performs some code clean-up labels Oct 24, 2026
@guedou
guedou force-pushed the fix/issue-3938-skinny-contrib branch from 68d9e01 to b6ef816 Compare October 25, 2026 08:31
@guedou
guedou force-pushed the fix/issue-3938-skinny-contrib branch from b6ef816 to cdcdef7 Compare October 25, 2026 08:46
@guedou
guedou requested review from gpotter2 and a balanced review from Copilot and removed request for Copilot October 25, 2026 09:56
@gpotter2
gpotter2 merged commit 78a2def into secdev:master Oct 25, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Performs some code clean-up needs rework/cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants