Fix missing rank/type propagation after torch.cond (ONNX If node)#626
Draft
Copilot wants to merge 2 commits into
Draft
Fix missing rank/type propagation after torch.cond (ONNX If node)#626Copilot wants to merge 2 commits into
torch.cond (ONNX If node)#626Copilot wants to merge 2 commits into
Conversation
Co-authored-by: xadupre <22452781+xadupre@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing rank after a node in torch.cond
Fix missing rank/type propagation after Feb 25, 2026
torch.cond (ONNX If node)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After
aten_condcreates an ONNXIfnode, the outputs were left without rank, type, or shape metadata in the graph builder — meaning_known_ranks,_known_types, and_known_shapeshad no entries for those outputs. Any downstream optimization or graph-building pass that querieshas_rank()/get_rank()on those results would get empty or wrong answers.Changes
experimental_experiment/torch_interpreter/_aten_functions.py— Afterg.make_node("If", ...)inaten_cond, propagate rank/type/shape from thetrue_graphlocal function builder to eachIfoutput. The builder already has complete metadata since both branches were fully interpreted before this call. Mirrors the same pattern used for submodule functions ininterpreter.py.Works correctly for single-output, multi-output, and dynamic-shape cases (builders store dynamic dimension strings such as
's77')._unittests/ut_torch_interpreter/test_onnx_export_control_flow.py— Added three targeted tests covering single-output cond, multi-output cond, and cond with dynamic shapes.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.