Display: avoid to emit loginFailed twice #2137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We send a
loginFailedsignal on auth error handling (slotAuthError), as well as at the end of failed authorization process (slotAuthenticationFinished).As a result, most often these two events follow each other and two
loginFailedsignals for one auth error are sent to Greeter.This change adds a boolean to check whether we have already sent an
loginFailedduring auth error handling, so as not to send it again at the end of the process. At the same time, if we haven't sent it yet and we immediately got toslotAuthenticationFinished, then we'll send it there.