Always use QString::fromLocal8Bit for strings from POSIX API

davispuh · plfiorini · commit 433a19b12bd7 · 2015-08-22T09:05:27.000+02:00
Qt uses LC_* for locale and if they're set they take
precedence over anything else, but sddm would set them to empty string
if they weren't set before and that would ruin Qt system's locale
causing use of wrong encoding.

For proper i18n support need to ensure that LANG is set (from
/etc/locale.conf) and then always use QString::fromLocal8Bit for all
strings from POSIX API.

I would recommend enabling QT_NO_CAST_FROM_ASCII and don't use
QString(char *) but for POSIX API use fromLocal8Bit and for other
APIs use respective encoding for them.
diff --git a/src/greeter/UserModel.cpp b/src/greeter/UserModel.cpp
@@ -71,9 +71,9 @@ namespace SDDM {
 
             // create user
             UserPtr user { new User() };
-            user->name = QString(current_pw->pw_name);
-            user->realName = QString::fromUtf8(current_pw->pw_gecos).split(",").first();
-            user->homeDir = QString(current_pw->pw_dir);
+            user->name = QString::fromLocal8Bit(current_pw->pw_name);
+            user->realName = QString::fromLocal8Bit(current_pw->pw_gecos).split(",").first();
+            user->homeDir = QString::fromLocal8Bit(current_pw->pw_dir);
             user->uid = int(current_pw->pw_uid);
             user->gid = int(current_pw->pw_gid);
             // if shadow is used pw_passwd will be 'x' nevertheless, so this
