Pull version information from systel.local, when version info is not present #643
+36
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykaul
reviewed
Jan 1, 2026
| if server_version is None and dse_version is None: | ||
| local_query = QueryMessage( | ||
| query=maybe_add_timeout_to_query( | ||
| "SELECT * FROM system.local WHERE key='local'", |
There was a problem hiding this comment.
nit: do we need '*' here? Unsure, but I'm unsure if it matters much, or at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When metadata is refreshed for the first time node version information is not available.
But
get_schema_parserneeds it to pick correct parser class.We need to make driver pull that info from the
system.localwhen it is absent.Fixes: #640
Pre-review checklist
I have provided docstrings for the public items that I want to introduce.I have adjusted the documentation in./docs/source/.Fixes:annotations to PR description.