Repository navigation
Conversation
…ate. Following the approach in Gutenberg PR #85402, `index.html` becomes the theme's shell — the header part, the common `main` wrapper holding a `core/post-content` slot, and the footer part — while the seven other templates carry only what is particular to them. Each one names the template it is rendered inside in the new `templates` section of `theme.json`. Five of the seven compose to a block-for-block identical tree, so they render as they did before. The `404` and `page-no-title` templates adopt the shared `main` wrapper, so they lose their own padding and their zero top margin respectively. This relies on the `templates` section of `theme.json` and the template substitution added by Gutenberg PR #85402, neither of which core has yet. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following Gutenberg PR #85402,
index.htmlbecomes the theme's shell — the header part, the sharedmainwrapper holding acore/post-contentslot, and the footer part — while the seven other templates carry only what is particular to them. Each names the template it is rendered inside in the newtemplatessection oftheme.json, so the header and the footer live in one template instead of being repeated in eight. Five of the seven compose to a block-for-block identical tree and render exactly as they did before;404andpage-no-titleadopt the sharedmainwrapper, so they lose their own padding and their zero top margin respectively. This relies on thetemplatessection oftheme.jsonand thetemplate_includesubstitution added by that Gutenberg PR, neither of which core has, so on plain trunk the theme renders with no header and no footer. Verified by composing each child template intoindexwith the PR's substitution rules and diffing the resulting block tree against trunk; it has not yet been checked in a running site.Trac ticket: none. This is a companion to Gutenberg PR #85402 and is not proposed for core as it stands.
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: The template and
theme.jsonchanges, and a throwaway harness that verified the composed block trees against trunk. Directed and reviewed by me.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.