Added additional error conditions

michaelkourlas · michaelkourlas · commit 6e5ad19835c8 · 2014-05-27T09:02:04.000-04:00
diff --git a/lib/js2xmlparser.js b/lib/js2xmlparser.js
@@ -26,6 +26,9 @@
         if (typeof root !== "string") {
             throw new Error("root element must be a string");
         }
+        else if (root === "") {
+            throw new Error("root element cannot be empty");
+        }
 
         // Error checking and variable initialization for options
         if (typeof options === "object" && options !== null) {
@@ -106,6 +109,10 @@
             throw new Error("data must be an object or a string");
         }
 
+        if (Object.prototype.toString.call(data) === "[object Array]") {
+            throw new Error("data cannot be an array");
+        }
+
         if (typeof data === "string") {
             data = JSON.parse(data);
         }

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,9 @@`
`26`	`26`	`if (typeof root !== "string") {`
`27`	`27`	`throw new Error("root element must be a string");`
`28`	`28`	`}`
	`29`	`+ else if (root === "") {`
	`30`	`+ throw new Error("root element cannot be empty");`
	`31`	`+ }`
`29`	`32`
`30`	`33`	`// Error checking and variable initialization for options`
`31`	`34`	`if (typeof options === "object" && options !== null) {`
`@@ -106,6 +109,10 @@`
`106`	`109`	`throw new Error("data must be an object or a string");`
`107`	`110`	`}`
`108`	`111`
	`112`	`+ if (Object.prototype.toString.call(data) === "[object Array]") {`
	`113`	`+ throw new Error("data cannot be an array");`
	`114`	`+ }`
	`115`	`+`
`109`	`116`	`if (typeof data === "string") {`
`110`	`117`	`data = JSON.parse(data);`
`111`	`118`	`}`