add binstub and allow shebang #970
Conversation
Adding a shebang line processor to treat lines beginning with processor works, and updated existing unit tests to cover the new line processor.
scriptcs
Outdated
There was a problem hiding this comment.
I think this should probably live under /src/ScriptCs with Copy to Output Directory set to Copy Always, so it just gets emitted into bin/Release along with everything else.
|
I think this looks great! Perhaps we should just tidy up the location of the binstub and then I'd say it's good to merge! |
Moving to src/ScriptCs and including in csproj to Always CopyToOutputDirectory.
|
I've moved the binstub to src/ScriptCs and included it in the csproj with CopyToOutputDirectory=Always. It's including the file in the build output now, as well as the artifacts area on Windows and *nix; however, it's not being included in the NuGet package. If it's included in the NuGet package, I think it should be specifically excluded from the Chocolatey install? |
add binstub and allow shebang
|
@mbaker-dev thanks again. Just having the binstub in the artifacts is a step forward. At the moment we don't provide any packages for Linux or Mac, but I've made a note on #716 and #972 that we now have the binstub in the artifacts. |
|
This is getting exciting! |
4 participants
fixes #675 and #956
Raised on behalf of @mbaker-dev, even if just for discussion/review.