implemented PackagesWithDuplicateAssemblies scenario - fix for #953 #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khellang
added a commit
that referenced
this pull request
Mar 5, 2015
implemented PackagesWithDuplicateAssemblies scenario - fix for #953
Member
|
Looks good! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #953
In summary, all the duplicate reference logic, spanning both assemblies and paths is now encapsulated in
AssemblyReferenceswhich is an immutable data structure. All other objects no longer have this concern.By far the quickest and easiest way to review this PR will be one commit at a time. Each is isolated with a specific focus.