Skip to content

Conversation

@adamralph
Copy link
Contributor

fixes #785
includes #824

mbaker-dev and others added 2 commits March 3, 2015 02:32
Copy binaries to artifacts folder in build.sh and create artifacts/bin folder if it doesn't exist.
khellang added a commit that referenced this pull request Mar 3, 2015
Copy binaries to artifacts folder in build.sh #785
@khellang khellang merged commit 8088e2d into scriptcs:dev Mar 3, 2015
@khellang khellang added this to the v0.14 milestone Mar 3, 2015
@adamralph adamralph removed this from the v0.14 milestone Mar 3, 2015
@adamralph
Copy link
Contributor Author

Thanks @khellang.

I removed it from the 0.14 milestone since it doesn't affect the release in anyway. It's purely an enhancement to building from source on *nix.

@adamralph adamralph deleted the 785 branch March 3, 2015 11:58
@khellang
Copy link
Member

khellang commented Mar 3, 2015

OK, but isn't it still part of 0.14 (in time)? I'm used to assigning all merged PRs to the upcoming milestone, so it's easy to see what's been merged in which version.

@adamralph
Copy link
Contributor Author

It's a fair point. I guess can it can be viewed both ways.

To be honest, I kind of made up the milestone policy myself when I was curating the closed issues for the big 0.10 release (if which there were many) and I just found it easier to only assign issues to the milestone which actually affected the release. For that reason I generally excluded anything like build issues (although looking back it now that's not strictly true).

Aside from that, there is the whole PR vs issue thing, i.e. when a PR closes an issue do we do labelling and milestone assignment on both, or just one, and which one? Should we enforce that an issue is always raised for every functional change and a PR is simply a thing that closes one or more issues? (We do that in some other projects and it works well.)

We probably just need to agree our approach and put it on the wiki, e.g. https://github.com/FakeItEasy/FakeItEasy/wiki/Managing-pull-requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy binaries to artifacts folder in build.sh

3 participants