automatic filesystem migration #902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 351b0fc.
This reverts commit afdd6ef. Conflicts: test/ScriptCs.Tests.Acceptance/Support/ScriptDirectory.cs
- consistent command error logging - guard clauses - variable inlining - var keyword usage - line length - whitespace
- arrange/act/assert separation - consistent test pattern - redundant code - inline variables - line length - whitespace
Member
|
I think this looks nice. Had a couple of questions, but I think it's good to go. @adamralph Tell me if I should go ahead and merge anyway 😄 |
Contributor
Author
|
@khellang thanks for reviewing. With regard to the calls to As for the constants in the tests, I'm not huge fan of that. Constants are a mechanism for declaring something which is logically eternally constant so I would't make them public, and a private constant wouldn't achieve anything, so I'd prefer to leave as is. |
khellang
added a commit
that referenced
this pull request
Jan 23, 2015
automatic filesystem migration
Member
|
Time to close #884? |
Contributor
Author
|
Absolutely! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #626